[SPARK-38198][SQL][3.2] Fix QueryExecution.debug#toFile use the passed in maxFields when explainMode is CodegenMode #35515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n `maxFields` when `explainMode` is `CodegenMode` ### What changes were proposed in this pull request? `QueryExecution.debug#toFile` method supports passing in `maxFields` and this parameter will be passed down when `explainMode` is `SimpleMode`, `ExtendedMode`, or `CostMode`. But the passed down `maxFields` was ignored when `explainMode` is `CostMode` because `QueryExecution#stringWithStats` overrides it with `SQLConf.get.maxToStringFields` at present, so this pr removes the override behavior to let passed in `maxFields` take effect. ### Why are the changes needed? Bug fix ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GA and add a new test case Closes apache#35506 from LuciferYang/SPARK-38198. Authored-by: yangjie01 <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Contributor
Author
|
cc @MaxGekk |
MaxGekk
approved these changes
Feb 14, 2022
MaxGekk
pushed a commit
that referenced
this pull request
Feb 14, 2022
…d in maxFields when explainMode is CodegenMode ### What changes were proposed in this pull request? `QueryExecution.debug#toFile` method supports passing in `maxFields` and this parameter will be passed down when `explainMode` is `SimpleMode`, `ExtendedMode`, or `CostMode`. But the passed down `maxFields` was ignored when `explainMode` is `CostMode` because `QueryExecution#stringWithStats` overrides it with `SQLConf.get.maxToStringFields` at present, so this pr removes the override behavior to let passed in `maxFields` take effect. ### Why are the changes needed? Bug fix ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GA and add a new test case Closes #35515 from LuciferYang/SPARK-38198-32. Authored-by: yangjie01 <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Member
|
Merging to branch-3.2. Thank you, @LuciferYang . |
Contributor
Author
|
thanks @MaxGekk |
kazuyukitanimura
pushed a commit
to kazuyukitanimura/spark
that referenced
this pull request
Aug 10, 2022
…d in maxFields when explainMode is CodegenMode ### What changes were proposed in this pull request? `QueryExecution.debug#toFile` method supports passing in `maxFields` and this parameter will be passed down when `explainMode` is `SimpleMode`, `ExtendedMode`, or `CostMode`. But the passed down `maxFields` was ignored when `explainMode` is `CostMode` because `QueryExecution#stringWithStats` overrides it with `SQLConf.get.maxToStringFields` at present, so this pr removes the override behavior to let passed in `maxFields` take effect. ### Why are the changes needed? Bug fix ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GA and add a new test case Closes apache#35515 from LuciferYang/SPARK-38198-32. Authored-by: yangjie01 <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
QueryExecution.debug#toFilemethod supports passing inmaxFieldsand this parameter will be passed down whenexplainModeisSimpleMode,ExtendedMode, orCostMode.But the passed down
maxFieldswas ignored whenexplainModeisCostModebecauseQueryExecution#stringWithStatsoverrides it withSQLConf.get.maxToStringFieldsat present, so this pr removes the override behavior to let passed inmaxFieldstake effect.Why are the changes needed?
Bug fix
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GA and add a new test case