[SPARK-35836][SHUFFLE][CORE][TESTS] Removed the reference to spark.shuffle.push.based.enabled in ShuffleBlockPusherSuite #32992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mridulm Could you please help review this trivial change |
|
Can one of the admins verify this patch? |
mridulm
reviewed
Jun 21, 2021
core/src/test/scala/org/apache/spark/shuffle/ShuffleBlockPusherSuite.scala
Show resolved
Hide resolved
mridulm
approved these changes
Jun 21, 2021
Contributor
|
Thanks for fixing this @otterc |
dongjoon-hyun
changed the title
domybest11
pushed a commit
to domybest11/spark
that referenced
this pull request
Jun 15, 2022
…ush.based.enabled in ShuffleBlockPusherSuite ### What changes were proposed in this pull request? It is a trivial change to remove the reference to an incorrect configuration for push-based shuffle from a test suite. Ref: apache#30312 With SPARK-32917, `ShuffleBlockPusher` and its test suite was introduced. `ShuffleBlockPusher` is created only when push-based shuffle is enabled and the tests in `ShuffleBlockPusherSuite` are just testing the functionality in the pusher. So there is no need to have these configs enabled in these test. ### Why are the changes needed? This change removes an incorrect configuration from the test suite. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? This change just removes an incorrect configuration from the test suite so haven't added any UTs for it. Closes apache#32992 from otterc/SPARK-35836. Authored-by: Chandni Singh <[email protected]> Signed-off-by: Mridul Muralidharan <mridul<at>gmail.com>
wangyum
pushed a commit
that referenced
this pull request
May 26, 2023
…ush.based.enabled in ShuffleBlockPusherSuite ### What changes were proposed in this pull request? It is a trivial change to remove the reference to an incorrect configuration for push-based shuffle from a test suite. Ref: #30312 With SPARK-32917, `ShuffleBlockPusher` and its test suite was introduced. `ShuffleBlockPusher` is created only when push-based shuffle is enabled and the tests in `ShuffleBlockPusherSuite` are just testing the functionality in the pusher. So there is no need to have these configs enabled in these test. ### Why are the changes needed? This change removes an incorrect configuration from the test suite. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? This change just removes an incorrect configuration from the test suite so haven't added any UTs for it. Closes #32992 from otterc/SPARK-35836. Authored-by: Chandni Singh <[email protected]> Signed-off-by: Mridul Muralidharan <mridul<at>gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It is a trivial change to remove the reference to an incorrect configuration for push-based shuffle from a test suite.
Ref: #30312
With SPARK-32917,
ShuffleBlockPusherand its test suite was introduced.ShuffleBlockPusheris created only when push-based shuffle is enabled and the tests inShuffleBlockPusherSuiteare just testing the functionality in the pusher. So there is no need to have these configs enabled in these test.Why are the changes needed?
This change removes an incorrect configuration from the test suite.
Does this PR introduce any user-facing change?
No
How was this patch tested?
This change just removes an incorrect configuration from the test suite so haven't added any UTs for it.