Skip to content

Commit 562fb49

Browse files
ottercwakun
authored andcommitted
[SPARK-35836][SHUFFLE][CORE] Removed the reference to spark.shuffle.push.based.enabled in ShuffleBlockPusherSuite
### What changes were proposed in this pull request? It is a trivial change to remove the reference to an incorrect configuration for push-based shuffle from a test suite. Ref: #30312 With SPARK-32917, `ShuffleBlockPusher` and its test suite was introduced. `ShuffleBlockPusher` is created only when push-based shuffle is enabled and the tests in `ShuffleBlockPusherSuite` are just testing the functionality in the pusher. So there is no need to have these configs enabled in these test. ### Why are the changes needed? This change removes an incorrect configuration from the test suite. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? This change just removes an incorrect configuration from the test suite so haven't added any UTs for it. Closes #32992 from otterc/SPARK-35836. Authored-by: Chandni Singh <[email protected]> Signed-off-by: Mridul Muralidharan <mridul<at>gmail.com>
1 parent 0cd82f5 commit 562fb49

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

core/src/test/scala/org/apache/spark/shuffle/ShuffleBlockPusherSuite.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,6 @@ class ShuffleBlockPusherSuite extends SparkFunSuite with BeforeAndAfterEach {
5656
when(dependency.partitioner).thenReturn(new HashPartitioner(8))
5757
when(dependency.serializer).thenReturn(new JavaSerializer(conf))
5858
when(dependency.getMergerLocs).thenReturn(Seq(BlockManagerId("test-client", "test-client", 1)))
59-
conf.set("spark.shuffle.push.based.enabled", "true")
60-
conf.set("spark.shuffle.service.enabled", "true")
6159
// Set the env because the shuffler writer gets the shuffle client instance from the env.
6260
val mockEnv = mock(classOf[SparkEnv])
6361
when(mockEnv.conf).thenReturn(conf)

0 commit comments

Comments
 (0)