Skip to content

Conversation

@tanelk
Copy link
Contributor

@tanelk tanelk commented Mar 25, 2021

What changes were proposed in this pull request?

Update the plan stability golden files even if only the explain.txt changes.

This is resubmition of #31927. The schema for one of the TPCDS tables was updated and that changed the explain.txt for the q17.

Why are the changes needed?

Currently only simplified.txt change is checked. There are some PRs, that update the explain.txt, that do not change the simplified.txt.

Does this PR introduce any user-facing change?

No

How was this patch tested?

The updated golden files.

@github-actions github-actions bot added the SQL label Mar 25, 2021
@tanelk
Copy link
Contributor Author

tanelk commented Mar 25, 2021

@cloud-fan
In my first PR, there was an filter removed from the q17. @maropu restored it with the #31943.

Checking the explain.txt would have caught the typo, that @maropu fixed.

@maropu
Copy link
Member

maropu commented Mar 25, 2021

Ah, I see. My two PRs (#31943 and #31940 ) that have recently been merged was updating the plans....

@SparkQA
Copy link

SparkQA commented Mar 25, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41091/

@SparkQA
Copy link

SparkQA commented Mar 25, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41091/

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in 6ba8445 Mar 25, 2021
@SparkQA
Copy link

SparkQA commented Mar 25, 2021

Test build #136506 has finished for PR 31957 at commit 9d187b4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants