[SPARK-34842][SQL][TESTS] Corrects the type of date_dim.d_quarter_name in the TPCDS schema
#31943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
cloud-fan
approved these changes
Mar 23, 2021
|
Kubernetes integration test starting |
wangyum
approved these changes
Mar 23, 2021
HyukjinKwon
approved these changes
Mar 23, 2021
|
Kubernetes integration test status failure |
dongjoon-hyun
changed the title
date_dim.d_quarter_name in the TPCDS schemadate_dim.d_quarter_name in the TPCDS schema
dongjoon-hyun
pushed a commit
that referenced
this pull request
Mar 23, 2021
…me` in the TPCDS schema ### What changes were proposed in this pull request? SPARK-34842 (#31012) has a typo in the type of `date_dim.d_quarter_name` in the TPCDS schema (`TPCDSBase`). This PR replace `CHAR(1)` with `CHAR(6)`. This fix comes from p28 in [the TPCDS official doc](http://www.tpc.org/tpc_documents_current_versions/pdf/tpc-ds_v2.9.0.pdf). ### Why are the changes needed? Bugfix. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? N/A Closes #31943 from maropu/SPARK-34083-FOLLOWUP. Authored-by: Takeshi Yamamuro <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 0494dc9) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Thank you, @maropu and all. Merged to master/3.1. |
|
Test build #136402 has finished for PR 31943 at commit
|
Member
Author
|
Thanks, @dongjoon-hyun and all! |
flyrain
pushed a commit
to flyrain/spark
that referenced
this pull request
Sep 21, 2021
…me` in the TPCDS schema ### What changes were proposed in this pull request? SPARK-34842 (apache#31012) has a typo in the type of `date_dim.d_quarter_name` in the TPCDS schema (`TPCDSBase`). This PR replace `CHAR(1)` with `CHAR(6)`. This fix comes from p28 in [the TPCDS official doc](http://www.tpc.org/tpc_documents_current_versions/pdf/tpc-ds_v2.9.0.pdf). ### Why are the changes needed? Bugfix. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? N/A Closes apache#31943 from maropu/SPARK-34083-FOLLOWUP. Authored-by: Takeshi Yamamuro <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 0494dc9) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SPARK-34083 (#31012) has a typo in the type of
date_dim.d_quarter_namein the TPCDS schema (TPCDSBase). This PR replaceCHAR(1)withCHAR(6). This fix comes from p28 in the TPCDS official doc.Why are the changes needed?
Bugfix.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A