Skip to content

[SPARK-33908][CORE][FOLLOWUP] Correct Scaladoc of resolveDependencyPaths/resolveMavenDependencies #31016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[SPARK-33908][CORE][FOLLOWUP] Correct Scaladoc of resolveDependencyPaths/resolveMavenDependencies #31016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f36f6bf
[SPARK-33908][CORE][FLLOW-UP] Refactor SparkSubmitUtils.resolveMavenC…
AngersZhuuuu Jan 4, 2021
72eacfe
Update SparkSubmit.scala
AngersZhuuuu Jan 4, 2021
43672ae
Update SparkSubmit.scala
AngersZhuuuu Jan 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1194,11 +1194,11 @@ private[spark] object SparkSubmitUtils {
}

/**
* Output a comma-delimited list of paths for the downloaded jars to be added to the classpath
* Output a list of paths for the downloaded jars to be added to the classpath
* (will append to jars in SparkSubmit).
* @param artifacts Sequence of dependencies that were resolved and retrieved
* @param cacheDirectory directory where jars are cached
* @return a comma-delimited list of paths for the dependencies
* @param cacheDirectory Directory where jars are cached
* @return List of paths for the dependencies
*/
def resolveDependencyPaths(
artifacts: Array[AnyRef],
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/scala/org/apache/spark/util/DependencyUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ private[spark] object DependencyUtils extends Logging {
* 2. exclude: exclusion list when download Ivy URI jar and dependency jars.
* The `exclude` parameter content is a ',' separated `group:module` pair string :
* `exclude=group:module,group:module...`
* @return Comma separated string list of jars downloaded.
* @return List of jars downloaded.
*/
def resolveMavenDependencies(uri: URI): Seq[String] = {
val ivyProperties = DependencyUtils.getIvyProperties()
Expand Down