[SPARK-33908][CORE][FOLLOWUP] Correct Scaladoc of resolveDependencyPaths/resolveMavenDependencies #31016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oordinates() 's return parameter
Contributor
Author
xkrogen
reviewed
Jan 4, 2021
Contributor
xkrogen
left a comment
xkrogen
left a comment
There was a problem hiding this comment.
You missed one place in the Scaladoc.
Thanks for fixing this up!
| } | ||
|
|
||
| /** | ||
| * Output a comma-delimited list of paths for the downloaded jars to be added to the classpath |
Contributor
There was a problem hiding this comment.
"Output a comma-delimited list" needs updating as well
Contributor
Author
There was a problem hiding this comment.
"Output a comma-delimited list" needs updating as well
Emmmmm....,Updated ==
maropu
changed the title
maropu
approved these changes
Jan 4, 2021
Member
|
Pending GA. |
dongjoon-hyun
approved these changes
Jan 4, 2021
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @AngersZhuuuu and all.
Merged to master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix un-correct doc of last change #30922 (comment)
Why are the changes needed?
FIx doc
Does this PR introduce any user-facing change?
No
How was this patch tested?
Builds finished correctly.