Skip to content

[SPARK-32092][ML][PySpark][FOLLOWUP] Fixed CrossValidatorModel.copy() to copy models instead of list #29553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-32092][ML][PySpark][FOLLOWUP] Fixed CrossValidatorModel.copy() to copy models instead of list #29553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions python/pyspark/ml/tests/test_tuning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,9 @@ def test_copy(self):
'foo',
"Changing the original avgMetrics should not affect the copied model"
)
cvModel.subModels[0] = 'foo'
cvModel.subModels[0][0].getInducedError = lambda: 'foo'
self.assertNotEqual(
cvModelCopied.subModels[0],
cvModelCopied.subModels[0][0].getInducedError(),
'foo',
"Changing the original subModels should not affect the copied model"
)
Expand Down Expand Up @@ -852,9 +852,9 @@ def test_copy(self):
'foo',
"Changing the original validationMetrics should not affect the copied model"
)
tvsModel.subModels[0] = 'foo'
tvsModel.subModels[0].getInducedError = lambda: 'foo'
self.assertNotEqual(
tvsModelCopied.subModels[0],
tvsModelCopied.subModels[0].getInducedError(),
'foo',
"Changing the original subModels should not affect the copied model"
)
Expand Down
5 changes: 4 additions & 1 deletion python/pyspark/ml/tuning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,10 @@ def copy(self, extra=None):
extra = dict()
bestModel = self.bestModel.copy(extra)
avgMetrics = list(self.avgMetrics)
subModels = [model.copy() for model in self.subModels]
subModels = [
[sub_model.copy() for sub_model in fold_sub_models]
for fold_sub_models in self.subModels
]
return self._copyValues(CrossValidatorModel(bestModel, avgMetrics, subModels), extra=extra)

@since("2.3.0")
Expand Down