[SPARK-32092][ML][PySpark][FOLLOWUP] Fixed CrossValidatorModel.copy() to copy models instead of list #29553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
ok to test |
|
Test build #127940 has finished for PR 29553 at commit
|
viirya
approved these changes
Aug 26, 2020
Member
viirya
left a comment
viirya
left a comment
There was a problem hiding this comment.
This was merged in branch-3.0 previously, I think.
huaxingao
approved these changes
Aug 27, 2020
Contributor
|
Merged to master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixed
CrossValidatorModel.copy()so that it correctly calls.copy()on the models instead of lists of models.Why are the changes needed?
copy()was first changed in #29445 . The issue was found in CI of #29524 and fixed. This PR introduces the exact same change so thatCrossValidatorModel.copy()and its related tests are aligned in branchmasterand branchbranch-3.0.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Updated
test_copyto make surecopy()is called on models instead of lists of models.