[SPARK-32594][SQL][FOLLOWUP][test-hadoop2.7][test-hive1.2] Override get() and use Julian days in DaysWritable
#29523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks @MaxGekk |
Member
|
@MaxGekk This fix is also for branch-3.0, right? |
viirya
approved these changes
Aug 23, 2020
Member
Author
@viirya Yes. |
|
Test build #127811 has finished for PR 29523 at commit
|
Member
|
Github Actions was passed. |
Member
|
Thanks @MaxGekk. Merging this to master and branch-3.0. |
viirya
pushed a commit
that referenced
this pull request
Aug 23, 2020
…get()` and use Julian days in `DaysWritable` ### What changes were proposed in this pull request? Override `def get: Date` in `DaysWritable` use the `daysToMillis(int d)` from the parent class `DateWritable` instead of `long daysToMillis(int d, boolean doesTimeMatter)`. ### Why are the changes needed? It fixes failures of `HiveSerDeReadWriteSuite` with the profile `hive-1.2`. In that case, the parent class `DateWritable` has different implementation before the commit to Hive apache/hive@da3ed68. In particular, `get()` calls `new Date(daysToMillis(daysSinceEpoch))` instead of overrided `def get(doesTimeMatter: Boolean): Date` in the child class. The `get()` method returns wrong result `1970-01-01` because it uses not updated `daysSinceEpoch`. ### Does this PR introduce _any_ user-facing change? Yes. ### How was this patch tested? By running the test suite `HiveSerDeReadWriteSuite`: ``` $ build/sbt -Phive-1.2 -Phadoop-2.7 "test:testOnly org.apache.spark.sql.hive.execution.HiveSerDeReadWriteSuite" ``` and ``` $ build/sbt -Phive-2.3 -Phadoop-2.7 "test:testOnly org.apache.spark.sql.hive.execution.HiveSerDeReadWriteSuite" ``` Closes #29523 from MaxGekk/insert-date-into-hive-table-1.2. Authored-by: Max Gekk <[email protected]> Signed-off-by: Liang-Chi Hsieh <[email protected]> (cherry picked from commit 1c798f9) Signed-off-by: Liang-Chi Hsieh <[email protected]>
Member
|
Verified locally this fixed the test in branch-3.0 too. |
Member
|
late LGTM. Thanks for the fix, @MaxGekk ! |
Member
|
Thank you, @MaxGekk and all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Override
def get: DateinDaysWritableuse thedaysToMillis(int d)from the parent classDateWritableinstead oflong daysToMillis(int d, boolean doesTimeMatter).Why are the changes needed?
It fixes failures of
HiveSerDeReadWriteSuitewith the profilehive-1.2. In that case, the parent classDateWritablehas different implementation before the commit to Hive apache/hive@da3ed68. In particular,get()callsnew Date(daysToMillis(daysSinceEpoch))instead of overrideddef get(doesTimeMatter: Boolean): Datein the child class. Theget()method returns wrong result1970-01-01because it uses not updateddaysSinceEpoch.Does this PR introduce any user-facing change?
Yes.
How was this patch tested?
By running the test suite
HiveSerDeReadWriteSuite:and