-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-32608][SQL][3.0][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value #29521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
retest this please. |
Oh, I see. The fix LGTM |
|
Test build #127801 has finished for PR 29521 at commit
|
|
Test build #127802 has finished for PR 29521 at commit
|
|
retest this please |
|
Looks good pending test. |
|
@AngersZhuuuu btw, I think you'd better to run tests w/ |
Yea, missing this point before. |
|
Test build #127803 has finished for PR 29521 at commit
|
|
@viirya the failed UT not realetd to this pr and seems existed issue, is there any jira refer to this problem or need to fix this . |
|
I checked the commit history and #29409 and #29417 seem to be related to the failure: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127803/ |
Yes, they are known failure in hive-1.2. Please see https://issues.apache.org/jira/browse/SPARK-32689. |
Yeah, seems so. @MaxGekk the following two tests are failed in branch-3.0 and master under hive-1.2 profile now. org.apache.spark.sql.hive.execution.HiveSerDeReadWriteSuite.Read/Write Hive PARQUET serde table Could you help check and fix them? |
|
Jenkins shows this fixed ScriptTransformationSuite and others are known failures. Github Actions was passed except for |
…pt Transform ROW FORMAT DELIMIT value should format value ### What changes were proposed in this pull request? As mentioned in #29428 (comment) by viirya , fix bug in UT, since in script transformation no-serde mode, output of decimal is same in both hive-1.2/hive-2.3 ### Why are the changes needed? FIX UT ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? EXISTED UT Closes #29521 from AngersZhuuuu/SPARK-32608-3.0-FOLLOW-UP. Authored-by: angerszhu <[email protected]> Signed-off-by: Liang-Chi Hsieh <[email protected]>
|
Merging to branch-3.0. Thanks @AngersZhuuuu |
Here is the fix #29523 |
|
Thank you, @AngersZhuuuu and all. |
What changes were proposed in this pull request?
As mentioned in #29428 (comment) by @viirya ,
fix bug in UT, since in script transformation no-serde mode, output of decimal is same in both hive-1.2/hive-2.3
Why are the changes needed?
FIX UT
Does this PR introduce any user-facing change?
NO
How was this patch tested?
EXISTED UT