Skip to content

Conversation

@viirya
Copy link
Member

@viirya viirya commented Aug 23, 2020

What changes were proposed in this pull request?

This reverts commit e277ef1.

Why are the changes needed?

Because master and branch-3.0 both have few tests failed under hive-1.2 profile. And the PR #29457 missed a change in hive-1.2 code that causes compilation error. So it will make debugging the failed tests harder. I'd like revert #29457 first to unblock it.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Unit test

@maropu
Copy link
Member

maropu commented Aug 23, 2020

#29457 is related to branch-3.0? Looks like it was merged into master only though. Branch-3.0 has another reason for the test failure?

@viirya
Copy link
Member Author

viirya commented Aug 23, 2020

@maropu #29457 was not merged to branch-3.0, but only to master. Currently both master and branch-3.0 have some tests failed under hive-1.2 profile. #29457 isn't the cause of these failures, see #29518 (comment). But because #29457 missed a change in hive-1.2 code that causes compilation error, so it will block testing and debugging these failed test under hive-1.2 profile.

I'd like to unblock fixing the failed tests asap, so going to revert this.

@maropu
Copy link
Member

maropu commented Aug 23, 2020

cc: @zhengruifeng FYI (release managers)

@viirya
Copy link
Member Author

viirya commented Aug 23, 2020

I will merge this once Github Actions pass to unblock fixing tests.

@SparkQA
Copy link

SparkQA commented Aug 23, 2020

Test build #127797 has finished for PR 29519 at commit cfccfa6.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented Aug 23, 2020

@maropu Can you review this? GitHub Actions was passed.

@maropu
Copy link
Member

maropu commented Aug 23, 2020

I just compared the diffs with the original PR and it looks okay to revert it. Thanks, @viirya .

@viirya
Copy link
Member Author

viirya commented Aug 23, 2020

Thanks @maropu! Merging this to master and unblock test fixing!

@viirya viirya closed this in aa0b0b8 Aug 23, 2020
@viirya viirya deleted the revert-SPARK-32646 branch December 27, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants