Skip to content

Conversation

@viirya
Copy link
Member

@viirya viirya commented Aug 23, 2020

What changes were proposed in this pull request?

This is a followup of #29457 to fix a compilation error.

Why are the changes needed?

Fix a compilation error under hive1.2 profile.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Unit test.

@SparkQA

This comment has been minimized.

@viirya viirya force-pushed the fix-orc-pushdown-followup branch from 960e695 to 5ce7567 Compare August 23, 2020 02:33
@SparkQA
Copy link

SparkQA commented Aug 23, 2020

Test build #127796 has finished for PR 29518 at commit 5ce7567.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented Aug 23, 2020

To clarify:

The three tests are also failed in branch-3.0:

org.apache.spark.sql.hive.execution.HiveScriptTransformationSuite.SPARK-32608:  Script Transform ROW FORMAT DELIMIT value should format value
org.apache.spark.sql.hive.execution.HiveSerDeReadWriteSuite.Read/Write Hive PARQUET serde table
org.apache.spark.sql.hive.execution.HiveSerDeReadWriteSuite.Read/Write Hive TEXTFILE serde table

This test is failed before #29457. I manually checkouted to bf221de, and ran the test locally to verify.

org.apache.spark.sql.hive.orc.HiveOrcHadoopFsRelationSuite.save()/load()  - partitioned table - simple queries - partition columns in data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants