[SPARK-32468][SS][TESTS][FOLLOWUP] Provide "default.api.timeout.ms" as well when specifying "request.timeout.ms" on replacing "default.api.timeout.ms" #29343
Conversation
…s well when specifying "request.timeout.ms" to replace "default.api.timeout.ms"
|
Let's make sure Jenkins builds pass multiple times, and Github Action passes. |
|
retest this, please |
|
cc. @zsxwing as he reviewed #29272 |
|
retest this, please |
|
Test build #127015 has finished for PR 29343 at commit
|
|
retest this, please |
|
Test build #127017 has finished for PR 29343 at commit
|
|
retest this, please |
|
Looks good given the description and explanation. |
|
Thanks for working on this @HeartSaVioR. |
|
Test build #127018 has finished for PR 29343 at commit
|
|
Test build #127020 has finished for PR 29343 at commit
|
|
retest this, please |
|
Had a look, the explanation and solution makes sense. Thank you guys helping me out! |
|
I am going to merge this unblock other PRs. |
|
Merged to master. |
|
Thanks for the quick reviews & reaction! |
|
Test build #127028 has finished for PR 29343 at commit
|
…s well when specifying "request.timeout.ms" on replacing "default.api.timeout.ms" ### What changes were proposed in this pull request? This patch is a follow-up to fill the gap in apache#29272 which missed to also provide `default.api.timeout.ms` as well. apache#29272 unintentionally changed the behavior on Kafka side timeout which is incompatible with the test timeout. (`default.api.timeout.ms` gets default value which is 60 seconds, longer than test timeout.) ### Why are the changes needed? We realized the PR for SPARK-32468 (apache#29272) doesn't work as we expect. See apache#29272 (comment) for more details. ### Does this PR introduce _any_ user-facing change? No, as it only touches the tests. ### How was this patch tested? Will trigger builds from Jenkins or Github Action multiple time and confirm. Closes apache#29343 from HeartSaVioR/SPARK-32468-FOLLOWUP. Authored-by: Jungtaek Lim (HeartSaVioR) <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
4 participants
What changes were proposed in this pull request?
This patch is a follow-up to fill the gap in #29272 which missed to also provide
default.api.timeout.msas well. #29272 unintentionally changed the behavior on Kafka side timeout which is incompatible with the test timeout. (default.api.timeout.msgets default value which is 60 seconds, longer than test timeout.)Why are the changes needed?
We realized the PR for SPARK-32468 (#29272) doesn't work as we expect. See #29272 (comment) for more details.
Does this PR introduce any user-facing change?
No, as it only touches the tests.
How was this patch tested?
Will trigger builds from Jenkins or Github Action multiple time and confirm.