Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Apr 28, 2020

What changes were proposed in this pull request?

This PR aims to use r-lib/actions/setup-r because it's more stable and maintained by 3rd party.

Why are the changes needed?

This will recover the current outage. In addition, this will be more robust in the future.
As of now, this is tested via dongjoon-hyun#17 .

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the GitHub Actions, especially Linter R and Generate Documents.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM if it passes

@dongjoon-hyun
Copy link
Member Author

Thank you! I optimized a little by removing pandoc from Linter (R).

@HyukjinKwon
Copy link
Member

no problem. still lgtm as long as it fixes the build.

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Apr 28, 2020

Merged to master and branch-3.0. Seems we're all good.

HyukjinKwon pushed a commit that referenced this pull request Apr 28, 2020
### What changes were proposed in this pull request?

This PR aims to use `r-lib/actions/setup-r` because it's more stable and maintained by 3rd party.

### Why are the changes needed?

This will recover the current outage. In addition, this will be more robust in the future.
As of now, this is tested via dongjoon-hyun#17 .

### Does this PR introduce any user-facing change?

No.

### How was this patch tested?

Pass the GitHub Actions, especially `Linter R` and `Generate Documents`.

Closes #28382 from dongjoon-hyun/SPARK-31589.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: HyukjinKwon <[email protected]>
(cherry picked from commit 2d3e960)
Signed-off-by: HyukjinKwon <[email protected]>
@HyukjinKwon
Copy link
Member

It has a conflict against branch-2.4. Can you backport this too @dongjoon-hyun?

@dongjoon-hyun
Copy link
Member Author

Thank you. Sure!

@SparkQA
Copy link

SparkQA commented Apr 28, 2020

Test build #121952 has finished for PR 28382 at commit c6a8b12.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 28, 2020

Test build #121951 has finished for PR 28382 at commit 88ce87d.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants