Skip to content

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Apr 28, 2020

What changes were proposed in this pull request?

Currently R installation seems being failed in Github Actions:

Get:61 https://dl.bintray.com/sbt/debian  Packages [4174 B]
Get:62 http://ppa.launchpad.net/apt-fast/stable/ubuntu bionic/main amd64 Packages [532 B]
Get:63 http://ppa.launchpad.net/git-core/ppa/ubuntu bionic/main amd64 Packages [3036 B]
Get:64 http://ppa.launchpad.net/ondrej/php/ubuntu bionic/main amd64 Packages [52.0 kB]
Get:65 http://ppa.launchpad.net/ubuntu-toolchain-r/test/ubuntu bionic/main amd64 Packages [33.9 kB]
Get:66 http://ppa.launchpad.net/ubuntu-toolchain-r/test/ubuntu bionic/main Translation-en [10.1 kB]
Reading package lists...
E: The repository 'https://cloud.r-project.org/bin/linux/ubuntu bionic-cran35/ Release' does not have a Release file.
##[error]Process completed with exit code 100.

Why are the changes needed?

To fix the broken builds in Github Actions.

Does this PR introduce any user-facing change?

No, it's dev-only change.

How was this patch tested?

Github Actions build will test it out.

@MichaelChirico
Copy link
Contributor

There's another reference to this in dev/create-release/spark-rm/Dockerfile

@HyukjinKwon HyukjinKwon changed the title [SPARK-31587][R][INFRA] Fixes the repository for downloading R in Github Actions [WIP][SPARK-31587][R][INFRA] Fixes the repository for downloading R in Github Actions Apr 28, 2020
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the investigation and quick fix, @HyukjinKwon . I also noticed the failures are consistent. Let see the GitHub Action result~

@dongjoon-hyun
Copy link
Member

FYI, I checked the official README.

deb https://cloud.r-project.org/bin/linux/ubuntu bionic-cran35/

@HyukjinKwon HyukjinKwon changed the title [WIP][SPARK-31587][R][INFRA] Fixes the repository for downloading R in Github Actions [WIP][SPARK-31587][R][INFRA] Uses R 4.0.0 in Github Actions Apr 28, 2020
@HyukjinKwon
Copy link
Member Author

Yes .. I just checked too. Let me investigate a bit more.

@dongjoon-hyun
Copy link
Member

Thank you so much. Although I have no clue yet, Ubuntu OS might be changed by GitHub Action. Both Ubuntu and R released a new version.

@HyukjinKwon HyukjinKwon marked this pull request as draft April 28, 2020 02:36
@HyukjinKwon HyukjinKwon changed the title [WIP][SPARK-31587][R][INFRA] Uses R 4.0.0 in Github Actions [SPARK-31587][R][INFRA] Uses R 4.0.0 in Github Actions Apr 28, 2020
@HyukjinKwon
Copy link
Member Author

Yup, maybe it just needs some time to sync. Thanks for pointing these out @MichaelChirico and @dongjoon-hyun.

@MichaelChirico
Copy link
Contributor

While we're in this file, maybe update:

Rscript -e "devtools::install_github('jimhester/lintr')" && \

to use remotes instead? It's a more lightweight install than devtools.

Also lintr is now on CRAN:

https://cran.r-project.org/web/packages/lintr/index.html

Maybe we can drop devtools entirely and just install lintr in the line above?

@HyukjinKwon
Copy link
Member Author

devtools is used in other places too, e.g. devtools::document. I would just like to stick to it rather than having another dependency specifically in the CI.

lintr was being installed from the Github directly because they didn't bump up the major version for long time, which catches a lot of more instances. We could switch to the official release instead.

The problem here is that lintr isn't portable so Jenkins has the specific version of lintr. If we want to change, we should co-op to upgrade the lintr in our Jenkins machine too.

@MichaelChirico
Copy link
Contributor

OK so it's not an easy fix, should be addressed in a separate PR. NVM for now.

@HyukjinKwon
Copy link
Member Author

Closing in favour of #28382. We might still have to upgrade but the main issue it targets to fix is the build.

@SparkQA
Copy link

SparkQA commented Apr 28, 2020

Test build #121943 has finished for PR 28380 at commit 5dc15cd.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 28, 2020

Test build #121945 has finished for PR 28380 at commit 7203521.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon HyukjinKwon deleted the r-repo-addr branch July 27, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants