[SPARK-31578][R] Vectorize schema validation for arrow in types.R #28372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelChirico
changed the title
|
Test build #121913 has finished for PR 28372 at commit
|
|
Test build #121915 has finished for PR 28372 at commit
|
|
Test build #121918 has finished for PR 28372 at commit
|
HyukjinKwon
changed the title
HyukjinKwon
reviewed
Apr 28, 2020
HyukjinKwon
approved these changes
Apr 28, 2020
Member
|
I am going to merge. The tests are already passed, and I don't believe removing the return causes any test or build to break. |
Contributor
Author
|
linter failure looks transient to me:
|
HyukjinKwon
pushed a commit
that referenced
this pull request
Apr 28, 2020
### What changes were proposed in this pull request? Repeated `sapply` avoided in internal `checkSchemaInArrow` ### Why are the changes needed? Current implementation is doubly inefficient: 1. Repeatedly doing the same (95%) `sapply` loop 2. Doing scalar `==` on a vector (`==` should be done over the whole vector for efficiency) ### Does this PR introduce any user-facing change? No ### How was this patch tested? By my trusty friend the CI bots Closes #28372 from MichaelChirico/vectorize-types. Authored-by: Michael Chirico <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit 410fa91) Signed-off-by: HyukjinKwon <[email protected]>
|
Test build #121937 has finished for PR 28372 at commit
|
Member
|
Merged to master and branch-3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Repeated
sapplyavoided in internalcheckSchemaInArrowWhy are the changes needed?
Current implementation is doubly inefficient:
sapplyloop==on a vector (==should be done over the whole vector for efficiency)Does this PR introduce any user-facing change?
No
How was this patch tested?
By my trusty friend the CI bots