Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

This is a backport of #26827.

This PR aims to recover spark.ui.port and spark.blockManager.port from checkpoint like spark.driver.port.

Why are the changes needed?

When the user configures these values, we can respect them.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the Jenkins with the newly added test cases.

…eckpoint

### What changes were proposed in this pull request?

This PR aims to recover `spark.ui.port` and `spark.blockManager.port` from checkpoint like `spark.driver.port`.

### Why are the changes needed?

When the user configures these values, we can respect them.

### Does this PR introduce any user-facing change?

No.

### How was this patch tested?

Pass the Jenkins with the newly added test cases.

Closes #26827 from dongjoon-hyun/SPARK-30199.

Authored-by: Aaruna <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
@dongjoon-hyun
Copy link
Member Author

This is requested by 2.4.6 release manager as SPARK-31544.
But, for traceability, I keep SPARK-30199 as a PR title. Please update both JIRAs when merging.

cc @holdenk since she is 2.4.6 release manager.
cc @gatorsmile since he asked a one-by-one review for backporting.
cc @aaruna since he is the original author of the patch. In master/3.0 and this PR, the authorship is @aaruna always.

Although SPARK-30199 is categorized as an improvement originally, I'm also supporting @holdenk 's decision on SPARK-31544 as a bug fix.

cc @dbtsai

@holdenk
Copy link
Contributor

holdenk commented Apr 23, 2020

I think this looks good to me, pending Jenkins. If folks disagree about it being a bugfix I'm ok with us skipping it (although I think it's more bugfix than improvement).

@SparkQA
Copy link

SparkQA commented Apr 23, 2020

Test build #121699 has finished for PR 28320 at commit 0c14b27.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dbtsai
Copy link
Member

dbtsai commented Apr 24, 2020

LGTM. Thanks!

@aaruna
Copy link
Contributor

aaruna commented Apr 24, 2020

LGTM, thanks for the backport!

@dongjoon-hyun
Copy link
Member Author

Thank you, @holdenk , @dbtsai , @aaruna .
Merged to branch-2.4 for Apache Spark 2.4.6 release.

dongjoon-hyun pushed a commit that referenced this pull request Apr 24, 2020
…eckpoint

### What changes were proposed in this pull request?

This is a backport of #26827.

This PR aims to recover `spark.ui.port` and `spark.blockManager.port` from checkpoint like `spark.driver.port`.

### Why are the changes needed?

When the user configures these values, we can respect them.

### Does this PR introduce any user-facing change?

No.

### How was this patch tested?

Pass the Jenkins with the newly added test cases.

Closes #28320 from dongjoon-hyun/SPARK-30199-2.4.

Authored-by: Aaruna <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
@dongjoon-hyun dongjoon-hyun deleted the SPARK-30199-2.4 branch April 24, 2020 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants