Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

This PR aims to recover spark.ui.port and spark.blockManager.port from checkpoint like spark.driver.port.

Why are the changes needed?

When the user configures these values, we can respect them.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the Jenkins with the newly added test cases.

@dongjoon-hyun
Copy link
Member Author

cc @dbtsai

@ScrapCodes
Copy link
Member

Hi @dongjoon-hyun, Can you please explain, how it is useful to recover these port numbers from checkpoint. As these can be picked up from configuration, and may not always be desirable to be picked from checkpoint. For instance the ports availability change between the two runs.

@SparkQA
Copy link

SparkQA commented Dec 10, 2019

Test build #115087 has finished for PR 26827 at commit 771ac88.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 10, 2019

Test build #115089 has finished for PR 26827 at commit cfa7494.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Thank you for review, @ScrapCodes . This PR aims to keep only user-given port numbers like spark.driver.port. You can see the UT about that.

As these can be picked up from configuration, and may not always be desirable to be picked from checkpoint. For instance the ports availability change between the two runs.

@dongjoon-hyun
Copy link
Member Author

Hi, @jerryshao . Could you review this PR? This is basically the same with your spark.driver.port PR (#5060)

@jerryshao
Copy link
Contributor

The fix LGTM.

@dongjoon-hyun
Copy link
Member Author

Thank you so much, @jerryshao !

@dongjoon-hyun
Copy link
Member Author

Merged to master.

dongjoon-hyun pushed a commit that referenced this pull request Apr 24, 2020
…eckpoint

### What changes were proposed in this pull request?

This is a backport of #26827.

This PR aims to recover `spark.ui.port` and `spark.blockManager.port` from checkpoint like `spark.driver.port`.

### Why are the changes needed?

When the user configures these values, we can respect them.

### Does this PR introduce any user-facing change?

No.

### How was this patch tested?

Pass the Jenkins with the newly added test cases.

Closes #28320 from dongjoon-hyun/SPARK-30199-2.4.

Authored-by: Aaruna <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants