-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-30199][DSTREAM] Recover spark.(ui|blockManager).port from checkpoint
#26827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @dbtsai |
…ort from checkpoint
|
Hi @dongjoon-hyun, Can you please explain, how it is useful to recover these port numbers from checkpoint. As these can be picked up from configuration, and may not always be desirable to be picked from checkpoint. For instance the ports availability change between the two runs. |
|
Test build #115087 has finished for PR 26827 at commit
|
|
Test build #115089 has finished for PR 26827 at commit
|
|
Thank you for review, @ScrapCodes . This PR aims to keep only user-given port numbers like
|
|
Hi, @jerryshao . Could you review this PR? This is basically the same with your |
|
The fix LGTM. |
|
Thank you so much, @jerryshao ! |
|
Merged to master. |
…eckpoint ### What changes were proposed in this pull request? This is a backport of #26827. This PR aims to recover `spark.ui.port` and `spark.blockManager.port` from checkpoint like `spark.driver.port`. ### Why are the changes needed? When the user configures these values, we can respect them. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Pass the Jenkins with the newly added test cases. Closes #28320 from dongjoon-hyun/SPARK-30199-2.4. Authored-by: Aaruna <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
What changes were proposed in this pull request?
This PR aims to recover
spark.ui.portandspark.blockManager.portfrom checkpoint likespark.driver.port.Why are the changes needed?
When the user configures these values, we can respect them.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the Jenkins with the newly added test cases.