[SPARK-31330][INFRA][FOLLOW-UP] Exclude 'ui' and 'UI.scala' in CORE and 'dev/.rat-excludes' in BUILD autolabeller #28228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
nchammas
approved these changes
Apr 16, 2020
Member
Author
|
Thank you guys.. Let me merge this in because none of CI builds are related to this change :-). |
Member
Author
|
Merged to master. |
|
Test build #121343 has finished for PR 28228 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR excludes
uidirectly andUI.scalaconfiguration file inCORElabel, and excludedev/.rat-excludesinBUILDlabel in autolabeller. See #28218, #28217, #28214 and #28213There are some contexts about this #28114.
The syntax is from https://git-scm.com/docs/gitignore#_pattern_format (see also https://github.com/kaelzhang/node-ignore)
Why are the changes needed?
To label UI component properly.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
It uses the same syntax used for other places. I expect to see the actual results after it gets merged as it's difficult to test it out.