[SPARK-31446][WEBUI] Make html elements for a paged table possible to have different id attribute. #28217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #121289 has finished for PR 28217 at commit
|
Member
Author
|
retest this please. |
|
Test build #121293 has finished for PR 28217 at commit
|
HyukjinKwon
added a commit
that referenced
this pull request
Apr 16, 2020
…nd 'dev/.rat-excludes' in BUILD autolabeller ### What changes were proposed in this pull request? This PR excludes `ui` directly and `UI.scala` configuration file in `CORE` label, and exclude `dev/.rat-excludes` in `BUILD` label in autolabeller. See #28218, #28217, #28214 and #28213 There are some contexts about this #28114. The syntax is from https://git-scm.com/docs/gitignore#_pattern_format (see also https://github.com/kaelzhang/node-ignore) ### Why are the changes needed? To label UI component properly. ### Does this PR introduce any user-facing change? No, dev-only. ### How was this patch tested? It uses the same syntax used for other places. I expect to see the actual results after it gets merged as it's difficult to test it out. Closes #28228 from HyukjinKwon/SPARK-31330-followup. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
srowen
approved these changes
Apr 16, 2020
Member
|
Could you make a backporting PR to |
Member
Author
|
@dongjoon-hyun Sure. I'll do it. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Apr 17, 2020
…le to have different id attribute ### What changes were proposed in this pull request? This PR backports #28217 to `branch-3.0`, making each id attribute for page navigations in a page unique. PagedTable#pageNavigation returns HTML elements representing a page navigation for a paged table. In the current implementation, the method generates an id and it's used for id attribute for a set of elements for the page navigation. But some pages have two page navigations so there are two set of elements where corresponding elements have the same id. For example, there are two form-completedJob-table-page id in JobsPage. ### Why are the changes needed? Each id attribute should be unique in a page. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? I added a test case for pageNavigation extended. I also manually tested that there were no warning messages for the uniqueness in JobsPage and JobPage. Closes #28246 from sarutak/backporting-SPARK-31446-branch-3.0. Authored-by: Kousuke Saruta <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR makes each id attribute for page navigations in a page unique.
PagedTable#pageNavigationreturns HTML elements representing a page navigation for a paged table.In the current implementation, the method generates an id and it's used for id attribute for a set of elements for the page navigation.
But some pages have two page navigations so there are two set of elements where corresponding elements have the same id.
For example, there are two
form-completedJob-table-pageid in JobsPage.Why are the changes needed?
Each id attribute should be unique in a page.
The following is a screenshot of warning messages shown with Chrome when I visit JobsPage (Firefox doesn't show in my environment).
Does this PR introduce any user-facing change?
No.
How was this patch tested?
I added a test case for
pageNavigationextended.I also manually tested that there were no warning messages for the uniqueness in JobsPage and JobPage.