Skip to content

[SPARK-30253][INFRA] Do not add commits when releasing preview version #26879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-30253][INFRA] Do not add commits when releasing preview version #26879

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b75e4d
Do not add commits when releasing preview version
wangyum Dec 13, 2019
c7cd6f9
Fix
wangyum Dec 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion dev/create-release/release-tag.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,11 @@ git commit -a -m "Preparing development version $NEXT_VERSION"
if ! is_dry_run; then
# Push changes
git push origin $RELEASE_TAG
Copy link
Member

@dongjoon-hyun dongjoon-hyun Dec 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this tag pointing at, @wangyum ?

Copy link
Member

@dongjoon-hyun dongjoon-hyun Dec 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we can have a pointer during vote like the following.

Copy link
Member Author

@wangyum wangyum Dec 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We still have a similar pointer. But we do not add any commits.

Copy link
Member

@dongjoon-hyun dongjoon-hyun Dec 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮 It's interesting. Does the pointer look like the following really?

Copy link
Member Author

@wangyum wangyum Dec 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an example: https://github.com/wangyum/spark/releases/tag/v3.0.0-preview2-rc1

Copy link
Member Author

@wangyum wangyum Dec 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v3.0.0-preview2-rc1: 1b41cb5

git push origin HEAD:$GIT_BRANCH
if [[ $RELEASE_VERSION != *"preview"* ]]; then
git push origin HEAD:$GIT_BRANCH
else
echo "It's preview release. We only push $RELEASE_TAG to remote."
fi

cd ..
rm -rf spark
Expand Down