[SPARK-30253][INFRA] Do not add commits when releasing preview version #26879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #115294 has finished for PR 26879 at commit
|
Member
|
|
Member
|
|
|
|
||
| if ! is_dry_run; then | ||
| # Push changes | ||
| git push origin $RELEASE_TAG |
Member
There was a problem hiding this comment.
I'm wondering if we can have a pointer during vote like the following.
Member
Author
There was a problem hiding this comment.
Yes. We still have a similar pointer. But we do not add any commits.
Member
There was a problem hiding this comment.
😮 It's interesting. Does the pointer look like the following really?
Member
Author
There was a problem hiding this comment.
This is an example: https://github.com/wangyum/spark/releases/tag/v3.0.0-preview2-rc1
Member
|
cc @gatorsmile |
|
Test build #115348 has finished for PR 26879 at commit
|
Member
Author
|
I'm merging it and will be releasing preview2 soon. |
Member
Author
|
Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR add support do not add commits to master branch when releasing preview version.
Why are the changes needed?
We need manual revert this change, example:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
manual test