Skip to content

[SPARK-27690][SQL] Remove materialized views first in HiveClientImpl.reset #24592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-27690][SQL] Remove materialized views first in HiveClientImpl.reset #24592

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ee5b7a
Remove materialized view first
wangyum May 13, 2019
953194d
Reduce change
wangyum May 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -856,9 +856,20 @@ private[hive] class HiveClientImpl(
}

def reset(): Unit = withHiveState {
client.getAllTables("default").asScala.foreach { t =>
val allTables = client.getAllTables("default")
val (mvs, others) = allTables.asScala.map(t => client.getTable("default", t))
.partition(_.getTableType.toString.equals("MATERIALIZED_VIEW"))

// Remove materialized view first, otherwise caused a violation of foreign key constraint.
Copy link
Member

@gatorsmile gatorsmile May 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have the same issue for Hive indexes? Also, we normally also added a test case in the Version Suite. You can do it by using the method runSqlHive(sql: String) to create materialized views.

Copy link
Member Author

@wangyum wangyum May 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test in another PR: #23992

Copy link
Member Author

@wangyum wangyum May 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue only occurs with materialized views in Hive 3.1.
I have tested the index and the view.

mvs.foreach { table =>
val t = table.getTableName
logDebug(s"Deleting materialized view $t")
client.dropTable("default", t)
}

others.foreach { table =>
val t = table.getTableName
logDebug(s"Deleting table $t")
val table = client.getTable("default", t)
try {
client.getIndexes("default", t, 255).asScala.foreach { index =>
shim.dropIndex(client, "default", t, index.getIndexName)
Expand Down