[SPARK-27690][SQL] Remove materialized views first in HiveClientImpl.reset
#24592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
Outdated
Show resolved
Hide resolved
|
Test build #105361 has finished for PR 24592 at commit
|
dongjoon-hyun
changed the title
HiveClientImpl.reset
dongjoon-hyun
changed the title
HiveClientImpl.resetHiveClientImpl.reset
Member
|
Thank you for updating, @wangyum ! |
|
Test build #105368 has finished for PR 24592 at commit
|
dongjoon-hyun
approved these changes
May 14, 2019
Member
There was a problem hiding this comment.
+1, LGTM. Merged to master. Thank you, @wangyum .
cc @gatorsmile .
gatorsmile
reviewed
May 15, 2019
| val (mvs, others) = allTables.asScala.map(t => client.getTable("default", t)) | ||
| .partition(_.getTableType.toString.equals("MATERIALIZED_VIEW")) | ||
|
|
||
| // Remove materialized view first, otherwise caused a violation of foreign key constraint. |
Member
There was a problem hiding this comment.
Do we have the same issue for Hive indexes? Also, we normally also added a test case in the Version Suite. You can do it by using the method runSqlHive(sql: String) to create materialized views.
Member
Author
There was a problem hiding this comment.
This issue only occurs with materialized views in Hive 3.1.
I have tested the index and the view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We should remove materialized view first otherwise(note that Hive 3.1 could reproduce this issue):
How was this patch tested?
Existing test