Skip to content

[MINOR][DSTREAMS] Add DStreamCheckpointData.cleanup warning if delete returns false #24263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[MINOR][DSTREAMS] Add DStreamCheckpointData.cleanup warning if delete returns false #24263

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b1bcdc
[MINOR][DSTREAMS] Add DStreamCheckpointData.cleanup warning if delete…
gaborgsomogyi Apr 1, 2019
859e6f9
Either success or failed message
gaborgsomogyi Apr 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions streaming/src/main/scala/org/apache/spark/streaming/dstream/DStreamCheckpointData.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,12 @@ class DStreamCheckpointData[T: ClassTag](dstream: DStream[T])
if (fileSystem == null) {
fileSystem = path.getFileSystem(dstream.ssc.sparkContext.hadoopConfiguration)
}
fileSystem.delete(path, true)
if (fileSystem.delete(path, true)) {
logInfo("Deleted checkpoint file '" + file + "' for time " + time)
Copy link
Member

@srowen srowen Apr 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're welcome to use string interpolation here while you're at it, this seems fine

} else {
logWarning(s"Error deleting old checkpoint file '$file' for time $time")
}
timeToCheckpointFile -= time
logInfo("Deleted checkpoint file '" + file + "' for time " + time)
} catch {
case e: Exception =>
logWarning("Error deleting old checkpoint file '" + file + "' for time " + time, e)
Expand Down