[MINOR][DSTREAMS] Add DStreamCheckpointData.cleanup warning if delete returns false #24263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @srowen |
|
Test build #104162 has finished for PR 24263 at commit
|
srowen
approved these changes
Apr 1, 2019
HyukjinKwon
reviewed
Apr 1, 2019
streaming/src/main/scala/org/apache/spark/streaming/dstream/DStreamCheckpointData.scala
Outdated
Show resolved
Hide resolved
|
Test build #104191 has finished for PR 24263 at commit
|
srowen
approved these changes
Apr 2, 2019
| } | ||
| fileSystem.delete(path, true) | ||
| if (fileSystem.delete(path, true)) { | ||
| logInfo("Deleted checkpoint file '" + file + "' for time " + time) |
Member
There was a problem hiding this comment.
While you're welcome to use string interpolation here while you're at it, this seems fine
Member
|
Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
While I was reviewing #24235 I've found a minor addition possibility. Namely
FileSystem.deletereturns a boolean which is not yet checked. In this PR I've added a warning message when it returns false. I've added this as MINOR because no control flow change introduced.How was this patch tested?
Existing unit tests.