[SPARK-21646][SQL] Add new type coercion to compatible with Hive #23626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val typeCoercionMode = | ||
| buildConf("spark.sql.typeCoercion.mode") | ||
| .doc("Since Spark 2.4, the 'hive' mode is introduced for Hive compatiblity. " + | ||
| "Spark SQL has its native type cocersion mode, which is enabled by default.") |
There was a problem hiding this comment.
I like that you added documentation. Did you mean "coercion" rather than "cocersion"?
|
Can one of the admins verify this patch? |
Member
|
I doubt it if Spark SQL should support Hive compatible type coercion. What about making Spark's type coercion more reasonable in general? |
Contributor
Author
|
So, should we close this pr? |
Member
|
Yea, let's close this one for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Ref to: #18853
I found that pr 18853 hasn't been merged for long time due to some conflicts，and I solved these conflicts and merged
How was this patch tested?
unit tests