Skip to content

[SPARK-25456][SQL][TEST] Fix PythonForeachWriterSuite #22452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-25456][SQL][TEST] Fix PythonForeachWriterSuite #22452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/python/PythonForeachWriterSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,20 @@ package org.apache.spark.sql.execution.python

import scala.collection.mutable.ArrayBuffer

import org.mockito.Mockito.when
import org.scalatest.concurrent.Eventually
import org.scalatest.mockito.MockitoSugar
import org.scalatest.time.SpanSugar._

import org.apache.spark._
import org.apache.spark.memory.{TaskMemoryManager, TestMemoryManager}
import org.apache.spark.serializer.{JavaSerializer, SerializerManager}
import org.apache.spark.sql.catalyst.expressions.{GenericInternalRow, UnsafeProjection}
import org.apache.spark.sql.execution.python.PythonForeachWriter.UnsafeRowBuffer
import org.apache.spark.sql.types.{DataType, IntegerType}
import org.apache.spark.util.Utils

class PythonForeachWriterSuite extends SparkFunSuite with Eventually {
class PythonForeachWriterSuite extends SparkFunSuite with Eventually with MockitoSugar {

testWithBuffer("UnsafeRowBuffer: iterator blocks when no data is available") { b =>
b.assertIteratorBlocked()
Expand Down Expand Up @@ -75,15 +78,20 @@ class PythonForeachWriterSuite extends SparkFunSuite with Eventually {
tester = new BufferTester(memBytes, sleepPerRowReadMs)
f(tester)
} finally {
if (tester == null) tester.close()
if (tester != null) tester.close()
Copy link
Member

@xuanyuanking xuanyuanking Sep 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e... So here's why all test failed with NPE.

Copy link
Contributor Author

@squito squito Sep 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but that NPE just covered up another NPE from SparkEnv.get.serializerManager

}
}
}


class BufferTester(memBytes: Long, sleepPerRowReadMs: Int) {
private val buffer = {
val mem = new TestMemoryManager(new SparkConf())
val mockEnv = mock[SparkEnv]
val conf = new SparkConf()
val serializerManager = new SerializerManager(new JavaSerializer(conf), conf, None)
when(mockEnv.serializerManager).thenReturn(serializerManager)
SparkEnv.set(mockEnv)
val mem = new TestMemoryManager(conf)
mem.limit(memBytes)
val taskM = new TaskMemoryManager(mem, 0)
new UnsafeRowBuffer(taskM, Utils.createTempDir(), 1)
Expand Down