[SPARK-25456][SQL][TEST] Fix PythonForeachWriterSuite #22452
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| f(tester) | ||
| } finally { | ||
| if (tester == null) tester.close() | ||
| if (tester != null) tester.close() |
Member
There was a problem hiding this comment.
e... So here's why all test failed with NPE.
Contributor
Author
There was a problem hiding this comment.
yes, but that NPE just covered up another NPE from SparkEnv.get.serializerManager
|
Test build #96183 has finished for PR 22452 at commit
|
Contributor
Author
|
Jenkins, retest this please |
Contributor
|
LGTM |
|
Test build #96189 has finished for PR 22452 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Sep 18, 2018
PythonForeachWriterSuite was failing because RowQueue now needs to have a handle on a SparkEnv with a SerializerManager, so added a mock env with a serializer manager. Also fixed a typo in the `finally` that was hiding the real exception. Tested PythonForeachWriterSuite locally, full tests via jenkins. Closes #22452 from squito/SPARK-25456. Authored-by: Imran Rashid <[email protected]> Signed-off-by: Imran Rashid <[email protected]> (cherry picked from commit a6f37b0) Signed-off-by: Imran Rashid <[email protected]>
Contributor
Author
|
merged to master & 2.4 |
This was referenced Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PythonForeachWriterSuite was failing because RowQueue now needs to have a handle on a SparkEnv with a SerializerManager, so added a mock env with a serializer manager.
Also fixed a typo in the
finallythat was hiding the real exception.Tested PythonForeachWriterSuite locally, full tests via jenkins.