Skip to content

[SPARK-25375][SQL][TEST] Reenable qualified perm. function checks in UDFSuite #22363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-25375][SQL][TEST] Reenable qualified perm. function checks in UDFSuite #22363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions sql/hive/src/test/scala/org/apache/spark/sql/hive/UDFSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,10 @@ class UDFSuite
withTempDatabase { dbName =>
withUserDefinedFunction(functionName -> false) {
sql(s"CREATE FUNCTION $dbName.$functionName AS '$functionClass'")
// TODO: Re-enable it after can distinguish qualified and unqualified function name
// checkAnswer(
// sql(s"SELECT $dbName.myuPPer(value) from $testTableName"),
// expectedDF
// )
checkAnswer(
sql(s"SELECT $dbName.$functionName(value) from $testTableName"),
expectedDF
)

checkAnswer(
sql(s"SHOW FUNCTIONS like $dbName.$functionNameUpper"),
Expand Down Expand Up @@ -174,11 +173,10 @@ class UDFSuite
// For this block, drop function command uses default.functionName as the function name.
withUserDefinedFunction(s"$dbName.$functionNameUpper" -> false) {
sql(s"CREATE FUNCTION $dbName.$functionName AS '$functionClass'")
// TODO: Re-enable it after can distinguish qualified and unqualified function name
// checkAnswer(
// sql(s"SELECT $dbName.myupper(value) from $testTableName"),
// expectedDF
// )
checkAnswer(
sql(s"SELECT $dbName.$functionName(value) from $testTableName"),
expectedDF
)

sql(s"USE $dbName")

Expand Down