[SPARK-25375][SQL][TEST] Reenable qualified perm. function checks in UDFSuite #22363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Hi, @yhuai . |
Member
|
LGTM |
Member
Author
|
Thank you for review, @maropu . |
|
Test build #95816 has finished for PR 22363 at commit
|
HyukjinKwon
approved these changes
Sep 8, 2018
Member
Author
|
Thank you for review and approval, @HyukjinKwon . |
Member
Author
|
cc @cloud-fan and @gatorsmile |
gatorsmile
reviewed
Sep 8, 2018
Member
gatorsmile
left a comment
gatorsmile
left a comment
There was a problem hiding this comment.
LGTM
Thanks! Merged to 2.4 and master
asfgit
pushed a commit
that referenced
this pull request
Sep 8, 2018
…UDFSuite ## What changes were proposed in this pull request? At Spark 2.0.0, SPARK-14335 adds some [commented-out test coverages](https://github.com/apache/spark/pull/12117/files#diff-dd4b39a56fac28b1ced6184453a47358R177 ). This PR enables them because it's supported since 2.0.0. ## How was this patch tested? Pass the Jenkins with re-enabled test coverage. Closes #22363 from dongjoon-hyun/SPARK-25375. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: gatorsmile <[email protected]> (cherry picked from commit 26f74b7) Signed-off-by: gatorsmile <[email protected]>
Member
Author
|
Thank you, @gatorsmile ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
At Spark 2.0.0, SPARK-14335 adds some commented-out test coverages. This PR enables them because it's supported since 2.0.0.
How was this patch tested?
Pass the Jenkins with re-enabled test coverage.