Skip to content

[MINOR][SS] Fix kafka-0-10-sql trivials #22342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[MINOR][SS] Fix kafka-0-10-sql trivials #22342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a5a7e8
Remove unused import from KafkaRelation
dongjinleekr Sep 5, 2018
3b9ea74
Remove unused import from KafkaOffsetRangeCalculator
dongjinleekr Sep 5, 2018
ee4e97a
Fix comments on KafkaStreamWriterFactory: it does not extend DataWrit…
dongjinleekr Sep 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...ka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetRangeCalculator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import org.apache.spark.sql.sources.v2.DataSourceOptions
private[kafka010] class KafkaOffsetRangeCalculator(val minPartitions: Option[Int]) {
require(minPartitions.isEmpty || minPartitions.get > 0)

import KafkaOffsetRangeCalculator._
/**
* Calculate the offset ranges that we are going to process this batch. If `minPartitions`
* is not set or is set less than or equal the number of `topicPartitions` that we're going to
Expand Down
1 change: 0 additions & 1 deletion external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaRelation.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

package org.apache.spark.sql.kafka010

import java.{util => ju}
import java.util.UUID

import org.apache.kafka.common.TopicPartition
Expand Down
4 changes: 2 additions & 2 deletions ...ka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaStreamingWriteSupport.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ class KafkaStreamingWriteSupport(
}

/**
* A [[DataWriterFactory]] for Kafka writing. Will be serialized and sent to executors to generate
* the per-task data writers.
* A [[StreamingDataWriterFactory]] for Kafka writing. Will be serialized and sent to executors to
* generate the per-task data writers.
* @param topic The topic that should be written to. If None, topic will be inferred from
* a `topic` field in the incoming data.
* @param producerParams Parameters for Kafka producers in each task.
Expand Down