[MINOR][SS] Fix kafka-0-10-sql trivials #22342
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjinleekr
changed the title
This comment has been minimized.
This comment has been minimized.
…erFactory from commit e754887.
dongjinleekr
force-pushed
the
feature/fix-kafka-sql-trivials
branch
from
f116d9e to
ee4e97a
Compare
|
Test build #95719 has finished for PR 22342 at commit
|
srowen
approved these changes
Sep 7, 2018
Member
|
It's fine. We usually don't do little minor cleanup PRs but it's reasonable for a new contributor to get warmed up like this. |
Member
|
Merged to master/2.4 |
asfgit
pushed a commit
that referenced
this pull request
Sep 7, 2018
## What changes were proposed in this pull request? Fix unused imports & outdated comments on `kafka-0-10-sql` module. (Found while I was working on [SPARK-23539](#22282)) ## How was this patch tested? Existing unit tests. Closes #22342 from dongjinleekr/feature/fix-kafka-sql-trivials. Authored-by: Lee Dongjin <[email protected]> Signed-off-by: Sean Owen <[email protected]> (cherry picked from commit 458f501) Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix unused imports & outdated comments on
kafka-0-10-sqlmodule. (Found while I was working on SPARK-23539)How was this patch tested?
Existing unit tests.