Skip to content

[SPARK-24350][SQL] Fixes ClassCastException in the "array_position" function #21401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-24350][SQL] Fixes ClassCastException in the "array_position" function #21401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e08bfc1
SPARK-24350 "array_position" error fix
wajda May 22, 2018
8e8f623
SPARK-24350 + error message check
wajda May 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...alyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1394,8 +1394,14 @@ case class ArrayPosition(left: Expression, right: Expression)
TypeUtils.getInterpretedOrdering(right.dataType)

override def dataType: DataType = LongType
override def inputTypes: Seq[AbstractDataType] =
Seq(ArrayType, left.dataType.asInstanceOf[ArrayType].elementType)

override def inputTypes: Seq[AbstractDataType] = {
val elementType = left.dataType match {
case t: ArrayType => t.elementType
case _ => AnyDataType
}
Seq(ArrayType, elementType)
}

override def checkInputDataTypes(): TypeCheckResult = {
super.checkInputDataTypes() match {
Expand Down
5 changes: 5 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,6 +708,11 @@ class DataFrameFunctionsSuite extends QueryTest with SharedSQLContext {
df.selectExpr("array_position(array(1, null), array(1, null)[0])"),
Seq(Row(1L), Row(1L))
)

val e = intercept[AnalysisException] {
Seq(("a string element", "a")).toDF().selectExpr("array_position(_1, _2)")
}
assert(e.message.contains("argument 1 requires array type, however, '`_1`' is of string type"))
}

test("element_at function") {
Expand Down