[SPARK-24350][SQL] Fixes ClassCastException in the "array_position" function

[wajda]

What changes were proposed in this pull request?

Fixes ClassCastException in the array_position function - SPARK-24350

When calling array_position function with a wrong type of the 1st argument an AnalysisException should be thrown instead of ClassCastException

Example:

select array_position('foo', 'bar')

java.lang.ClassCastException: org.apache.spark.sql.types.StringType$ cannot be cast to org.apache.spark.sql.types.ArrayType
	at org.apache.spark.sql.catalyst.expressions.ArrayPosition.inputTypes(collectionOperations.scala:1398)
	at org.apache.spark.sql.catalyst.expressions.ExpectsInputTypes$class.checkInputDataTypes(ExpectsInputTypes.scala:44)
	at org.apache.spark.sql.catalyst.expressions.ArrayPosition.checkInputDataTypes(collectionOperations.scala:1401)
	at org.apache.spark.sql.catalyst.expressions.Expression.resolved$lzycompute(Expression.scala:168)
	at org.apache.spark.sql.catalyst.expressions.Expression.resolved(Expression.scala:168)
	at org.apache.spark.sql.catalyst.analysis.Analyzer$ResolveAliases$$anonfun$org$apache$spark$sql$catalyst$analysis$Analyzer$ResolveAliases$$assignAliases$1$$anonfun$apply$3.applyOrElse(Analyzer.scala:256)
	at org.apache.spark.sql.catalyst.analysis.Analyzer$ResolveAliases$$anonfun$org$apache$spark$sql$catalyst$analysis$Analyzer$ResolveAliases$$assignAliases$1$$anonfun$apply$3.applyOrElse(Analyzer.scala:252)
	at org.apache.spark.sql.catalyst.trees.TreeNode$$anonfun$transformUp$1.apply(TreeNode.scala:289)
	at org.apache.spark.sql.catalyst.trees.TreeNode$$anonfun$transformUp$1.apply(TreeNode.scala:289)
	at org.apache.spark.sql.catalyst.trees.CurrentOrigin$.withOrigin(TreeNode.scala:70)
	at org.apache.spark.sql.catalyst.trees.TreeNode.transformUp(TreeNode.scala:288)

How was this patch tested?

unit test

[maropu]

Please check the error message, too.

[maropu]

Please describe more in the description; you'd be better to copy the description there.

[maropu]

@ueshin can you trigger tests?

[ueshin]

ok to test.

[SparkQA]

Test build #90990 has finished for PR 21401 at commit 8e8f623.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[wajda]

retest this please

[maropu]

retest this please

[viirya]

From PR description, Fixes ClassCastException in the array_position function - this seems like a better PR title than the current one.

[SparkQA]

Test build #91005 has finished for PR 21401 at commit 8e8f623.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[kiszk]

retest this please

[kiszk]

good catch, thanks

[SparkQA]

Test build #91015 has finished for PR 21401 at commit 8e8f623.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[ueshin]

Jenkins, retest this please.

[ueshin]

LGTM pending Jenkins.

[viirya]

LGTM

[SparkQA]

Test build #91020 has finished for PR 21401 at commit 8e8f623.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[gatorsmile]

retest this please

[SparkQA]

Test build #91045 has finished for PR 21401 at commit 8e8f623.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[kiszk]

retest this please

[kiszk]

LGTM

[SparkQA]

Test build #91058 has finished for PR 21401 at commit 8e8f623.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[gatorsmile]

LGTM

Thanks! Merged to master.