Skip to content

Conversation

@mgaido91
Copy link
Contributor

@mgaido91 mgaido91 commented Mar 16, 2018

What changes were proposed in this pull request?

SHS is using a relative path for the REST API call to get the list of the application is a relative path call. In case of the SHS being consumed through a proxy, it can be an issue if the path doesn't end with a "/".

Therefore, we should use an absolute path for the REST call as it is done for all the other resources.

How was this patch tested?

manual tests
Before the change:
screen shot 2018-03-10 at 4 22 02 pm

After the change:
screen shot 2018-03-10 at 4 36 34 pm 1

SHS is using a relative path for the REST API call to get the list of the application is a relative path call. In case of the SHS being consumed through a proxy, it can be an issue if the path doesn't end with a "/".

Therefore, we should use an absolute path for the REST call as it is done for all the other resources.

manual tests
Before the change:
![screen shot 2018-03-10 at 4 22 02 pm](https://user-images.githubusercontent.com/8821783/37244190-8ccf9d40-2485-11e8-8fa9-345bc81472fc.png)

After the change:
![screen shot 2018-03-10 at 4 36 34 pm 1](https://user-images.githubusercontent.com/8821783/37244201-a1922810-2485-11e8-8856-eeab2bf5e180.png)

Author: Marco Gaido <[email protected]>

Closes apache#20794 from mgaido91/SPARK-23644.
@mgaido91
Copy link
Contributor Author

cc @jerryshao

@SparkQA
Copy link

SparkQA commented Mar 16, 2018

Test build #88308 has finished for PR 20847 at commit f130a36.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mgaido91 mgaido91 changed the title [SPARK-23644][CORE][UI] Use absolute path for REST call in SHS [SPARK-23644][CORE][UI][BACKPORT-2.3] Use absolute path for REST call in SHS Mar 16, 2018
@mgaido91
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented Mar 16, 2018

Test build #88315 has finished for PR 20847 at commit f130a36.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk
Copy link
Member

kiszk commented Mar 16, 2018

retest this please

@SparkQA
Copy link

SparkQA commented Mar 16, 2018

Test build #88322 has finished for PR 20847 at commit f130a36.

  • This patch fails from timeout after a configured wait of `250m`.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Retest this please.

@SparkQA
Copy link

SparkQA commented Mar 17, 2018

Test build #88335 has finished for PR 20847 at commit f130a36.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mgaido91
Copy link
Contributor Author

most of the UTs are failing consistently and of course UTs failures are unrelated. Since this is on branch 2.3, shall we open a JIRA for tracking this?

@jerryshao
Copy link
Contributor

Jenkins, retest this please.

@jerryshao
Copy link
Contributor

@mgaido91 would you please create a JIRA to track all the UT failures. Hopes someone familiar with that part could fix them.

@SparkQA
Copy link

SparkQA commented Mar 19, 2018

Test build #88364 has finished for PR 20847 at commit f130a36.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jerryshao
Copy link
Contributor

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Mar 19, 2018

Test build #88371 has finished for PR 20847 at commit f130a36.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

The ML bug is fixed. I'll retrigger this.

@dongjoon-hyun
Copy link
Member

Retest this please.

@SparkQA
Copy link

SparkQA commented Mar 19, 2018

Test build #88382 has finished for PR 20847 at commit f130a36.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Retest this please.

@SparkQA
Copy link

SparkQA commented Mar 20, 2018

Test build #88387 has finished for PR 20847 at commit f130a36.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jerryshao
Copy link
Contributor

Thanks, merging to branch 2.3.

asfgit pushed a commit that referenced this pull request Mar 20, 2018
… in SHS

## What changes were proposed in this pull request?

SHS is using a relative path for the REST API call to get the list of the application is a relative path call. In case of the SHS being consumed through a proxy, it can be an issue if the path doesn't end with a "/".

Therefore, we should use an absolute path for the REST call as it is done for all the other resources.

## How was this patch tested?

manual tests
Before the change:
![screen shot 2018-03-10 at 4 22 02 pm](https://user-images.githubusercontent.com/8821783/37244190-8ccf9d40-2485-11e8-8fa9-345bc81472fc.png)

After the change:
![screen shot 2018-03-10 at 4 36 34 pm 1](https://user-images.githubusercontent.com/8821783/37244201-a1922810-2485-11e8-8856-eeab2bf5e180.png)

Author: Marco Gaido <[email protected]>

Closes #20847 from mgaido91/SPARK-23644_2.3.
@jerryshao
Copy link
Contributor

@mgaido91 this is already merged to branch 2.3. Please close this PR if it is not closed automatically.

@mgaido91 mgaido91 closed this Mar 20, 2018
@mgaido91 mgaido91 deleted the SPARK-23644_2.3 branch March 20, 2018 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants