-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-23644][CORE][UI][BACKPORT-2.3] Use absolute path for REST call in SHS #20847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SHS is using a relative path for the REST API call to get the list of the application is a relative path call. In case of the SHS being consumed through a proxy, it can be an issue if the path doesn't end with a "/". Therefore, we should use an absolute path for the REST call as it is done for all the other resources. manual tests Before the change:  After the change:  Author: Marco Gaido <[email protected]> Closes apache#20794 from mgaido91/SPARK-23644.
|
cc @jerryshao |
|
Test build #88308 has finished for PR 20847 at commit
|
|
retest this please |
|
Test build #88315 has finished for PR 20847 at commit
|
|
retest this please |
|
Test build #88322 has finished for PR 20847 at commit
|
|
Retest this please. |
|
Test build #88335 has finished for PR 20847 at commit
|
|
most of the UTs are failing consistently and of course UTs failures are unrelated. Since this is on branch 2.3, shall we open a JIRA for tracking this? |
|
Jenkins, retest this please. |
|
@mgaido91 would you please create a JIRA to track all the UT failures. Hopes someone familiar with that part could fix them. |
|
Test build #88364 has finished for PR 20847 at commit
|
|
Jenkins, retest this please. |
|
Test build #88371 has finished for PR 20847 at commit
|
|
The ML bug is fixed. I'll retrigger this. |
|
Retest this please. |
|
Test build #88382 has finished for PR 20847 at commit
|
|
Retest this please. |
|
Test build #88387 has finished for PR 20847 at commit
|
|
Thanks, merging to branch 2.3. |
… in SHS ## What changes were proposed in this pull request? SHS is using a relative path for the REST API call to get the list of the application is a relative path call. In case of the SHS being consumed through a proxy, it can be an issue if the path doesn't end with a "/". Therefore, we should use an absolute path for the REST call as it is done for all the other resources. ## How was this patch tested? manual tests Before the change:  After the change:  Author: Marco Gaido <[email protected]> Closes #20847 from mgaido91/SPARK-23644_2.3.
|
@mgaido91 this is already merged to branch 2.3. Please close this PR if it is not closed automatically. |
What changes were proposed in this pull request?
SHS is using a relative path for the REST API call to get the list of the application is a relative path call. In case of the SHS being consumed through a proxy, it can be an issue if the path doesn't end with a "/".
Therefore, we should use an absolute path for the REST call as it is done for all the other resources.
How was this patch tested?
manual tests

Before the change:
After the change:
