[SPARK-23644][CORE][UI] Use absolute path for REST call in SHS #20794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #88153 has finished for PR 20794 at commit
|
Contributor
|
Ping @ajbozarth . |
Contributor
|
The fix LGTM, also cc @gengliangwang |
Member
|
LGTM |
Contributor
|
Merging to master and brach 2.3. Thanks! |
Contributor
|
@mgaido91 the PR has conflict with branch 2.3, so I don't cherry-pick it to 2.3. If you want to backport, please create another backport PR. |
mgaido91
added a commit
to mgaido91/spark
that referenced
this pull request
Mar 16, 2018
SHS is using a relative path for the REST API call to get the list of the application is a relative path call. In case of the SHS being consumed through a proxy, it can be an issue if the path doesn't end with a "/". Therefore, we should use an absolute path for the REST call as it is done for all the other resources. manual tests Before the change:  After the change:  Author: Marco Gaido <[email protected]> Closes apache#20794 from mgaido91/SPARK-23644.
mstewart141
pushed a commit
to mstewart141/spark
that referenced
this pull request
Mar 24, 2018
## What changes were proposed in this pull request? SHS is using a relative path for the REST API call to get the list of the application is a relative path call. In case of the SHS being consumed through a proxy, it can be an issue if the path doesn't end with a "/". Therefore, we should use an absolute path for the REST call as it is done for all the other resources. ## How was this patch tested? manual tests Before the change:  After the change:  Author: Marco Gaido <[email protected]> Closes apache#20794 from mgaido91/SPARK-23644.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SHS is using a relative path for the REST API call to get the list of the application is a relative path call. In case of the SHS being consumed through a proxy, it can be an issue if the path doesn't end with a "/".
Therefore, we should use an absolute path for the REST call as it is done for all the other resources.
How was this patch tested?
manual tests
Before the change:
After the change:
