Skip to content

[SPARK-22907]Clean broadcast garbage when IOException occurred in MetadataFetch #20090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-22907]Clean broadcast garbage when IOException occurred in MetadataFetch #20090

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df9e052
Clean broadcast garbage when IOException occurred in MetadataFetch
Dec 27, 2017
cd4fd77
Update
Dec 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion core/src/main/scala/org/apache/spark/MapOutputTracker.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -829,10 +829,16 @@ private[spark] object MapOutputTracker extends Logging {
// deserialize the Broadcast, pull .value array out of it, and then deserialize that
val bcast = deserializeObject(bytes, 1, bytes.length - 1).
asInstanceOf[Broadcast[Array[Byte]]]
try {
logInfo("Broadcast mapstatuses size = " + bytes.length +
", actual size = " + bcast.value.length)
// Important - ignore the DIRECT tag ! Start from offset 1
deserializeObject(bcast.value, 1, bcast.value.length - 1).asInstanceOf[Array[MapStatus]]
deserializeObject(bcast.value, 1, bcast.value.length - 1).asInstanceOf[Array[MapStatus]]
} catch {
case e: IOException =>
SparkEnv.get.blockManager.removeBroadcast(bcast.id, false)
throw new IOException(s"Failed to read broadcast for mapstatuses", e)
}
case _ => throw new IllegalArgumentException("Unexpected byte tag = " + bytes(0))
}
}
Expand Down