[SPARK-22907]Clean broadcast garbage when IOException occurred in MetadataFetch #20090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 27, 2017 17:36
Summary: Ref T10399 Test Plan: n/a Reviewers: liushaohui, peng.zhang, zhoukang, chenfan Subscribers: cloud-computing Maniphest Tasks: T10399 Differential Revision: https://phabricator.d.xiaomi.net/D79279
Contributor
|
Thanks for submitting this @liupc. The jira description makes sense, though I need to take a closer look at the code to confirm things. But at least two things need to be fixed before this can be merged:
|
Contributor
|
ping @liupc |
|
Can one of the admins verify this patch? |
Member
|
ping @liupc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When fetching mapStatuses, IOException is not handled in MapOutputTracker.deserializeMapStatuses which might cause old broadcast not cleaned up. In task retrying, when task was scheduled to the executor where old broadcast was stored, An "Block is already present in the MemoryStore" exception would be thrown.
This PR will clean garbage broadcast when IOException occurred in MetadataFetch to avoid
repeated "Block is already present in the MemoryStore" caused by the uncleaned broadcast garbage
details see: https://issues.apache.org/jira/browse/SPARK-22907
(Please fill in changes proposed in this fix)
How was this patch tested?
manual
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.