Skip to content

[SPARK-22638][SS]Use a separate queue for StreamingQueryListenerBus #19838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-22638][SS]Use a separate queue for StreamingQueryListenerBus #19838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60035fa
Use a separate query for StreamingQueryListenerBus
zsxwing Nov 28, 2017
9b4ce99
Address Burak's comment
zsxwing Nov 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,9 @@ private[spark] class LiveListenerBus(conf: SparkConf) {
* of each other (each one uses a separate thread for delivering events), allowing slower
* listeners to be somewhat isolated from others.
*/
private def addToQueue(listener: SparkListenerInterface, queue: String): Unit = synchronized {
private[spark] def addToQueue(
Copy link
Contributor

@jiangxb1987 jiangxb1987 Nov 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to make this change?

Copy link
Member Author

@zsxwing zsxwing Nov 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change it in order to call it in StreamingQueryListenerBus.

listener: SparkListenerInterface,
queue: String): Unit = synchronized {
if (stopped.get()) {
throw new IllegalStateException("LiveListenerBus is stopped.")
}
Expand Down
6 changes: 5 additions & 1 deletion ...e/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingQueryListenerBus.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class StreamingQueryListenerBus(sparkListenerBus: LiveListenerBus)

import StreamingQueryListener._

sparkListenerBus.addToSharedQueue(this)
sparkListenerBus.addToQueue(this, StreamingQueryListenerBus.STREAM_EVENT_QUERY)

/**
* RunIds of active queries whose events are supposed to be forwarded by this ListenerBus
Expand Down Expand Up @@ -130,3 +130,7 @@ class StreamingQueryListenerBus(sparkListenerBus: LiveListenerBus)
}
}
}

object StreamingQueryListenerBus {
val STREAM_EVENT_QUERY = "streams"
}