[SPARK-22638][SS]Use a separate queue for StreamingQueryListenerBus #19838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #84274 has finished for PR 19838 at commit
|
jiangxb1987
reviewed
Nov 29, 2017
| * listeners to be somewhat isolated from others. | ||
| */ | ||
| private def addToQueue(listener: SparkListenerInterface, queue: String): Unit = synchronized { | ||
| private[spark] def addToQueue( |
Contributor
There was a problem hiding this comment.
Is it necessary to make this change?
Member
Author
There was a problem hiding this comment.
Change it in order to call it in StreamingQueryListenerBus.
brkyvz
reviewed
Nov 29, 2017
| import StreamingQueryListener._ | ||
|
|
||
| sparkListenerBus.addToSharedQueue(this) | ||
| sparkListenerBus.addToQueue(this, "streams") |
Contributor
There was a problem hiding this comment.
nit: wanna make this a constant?
Contributor
|
LGTM but I have very limited context on this codepath. Maybe @tdas can also take a very quick look? |
Contributor
|
Don't you mean "thread" instead of "query" in your summary? |
zsxwing
changed the title
Member
Author
|
@vanzin yeah. Good catch. Just a typo. |
|
Test build #84319 has finished for PR 19838 at commit
|
Contributor
|
LGTM. |
Member
Author
|
Thanks! Merging to master. |
asfgit
pushed a commit
that referenced
this pull request
Dec 1, 2017
## What changes were proposed in this pull request? Use a separate Spark event queue for StreamingQueryListenerBus so that if there are many non-streaming events, streaming query listeners don't need to wait for other Spark listeners and can catch up. ## How was this patch tested? Jenkins Author: Shixiong Zhu <[email protected]> Closes #19838 from zsxwing/SPARK-22638.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use a separate Spark event queue for StreamingQueryListenerBus so that if there are many non-streaming events, streaming query listeners don't need to wait for other Spark listeners and can catch up.
How was this patch tested?
Jenkins