Skip to content

[SPARK-22154] add a shutdown hook that explains why the output is terminating #19377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-22154] add a shutdown hook that explains why the output is terminating #19377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions core/src/main/scala/org/apache/spark/deploy/worker/CommandUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import org.apache.spark.SecurityManager
import org.apache.spark.deploy.Command
import org.apache.spark.internal.Logging
import org.apache.spark.launcher.WorkerCommandBuilder
import org.apache.spark.util.Utils
import org.apache.spark.util.{ShutdownHookManager, Utils}

/**
* Utilities for running commands with the spark classpath.
Expand Down Expand Up @@ -102,10 +102,14 @@ object CommandUtils extends Logging {
}

/** Spawn a thread that will redirect a given stream to a file */
private var shutdownHook: AnyRef = null
def redirectStream(in: InputStream, file: File) {
val out = new FileOutputStream(file, true)
// TODO: It would be nice to add a shutdown hook here that explains why the output is
// terminating. Otherwise if the worker dies the executor logs will silently stop.

shutdownHook = ShutdownHookManager.addShutdownHook { () =>
logInfo("Worker shutting down,executor logs silently stop.")
}

new Thread("redirect output to " + file) {
override def run() {
try {
Expand Down