Skip to content

Conversation

@liu-zhaokun
Copy link
Contributor

It would be nice to add a shutdown hook here that explains why the output is terminating. Otherwise if the worker dies the executor logs will silently stop.

@srowen
Copy link
Member

srowen commented Sep 28, 2017

The events of a shutdown are already logged; what does this add? it's already clear something is shutting down

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@liu-zhaokun
Copy link
Contributor Author

It says that "It would be nice to add a shutdown hook here that explains why the output is terminating. Otherwise if the worker dies the executor logs will silently stop" in "TODO",I think it is justified.

@srowen
Copy link
Member

srowen commented Sep 28, 2017

Why a shutdown hook instead of something in the lifecycle of this process?

@liu-zhaokun
Copy link
Contributor Author

@srowen
Sorry,I do not understand what you mean,could you explain it again?

@srowen
Copy link
Member

srowen commented Sep 28, 2017

Where does the worker exit normally or in case of an error? Why not log there?

@liu-zhaokun
Copy link
Contributor Author

@srowen
This hook is only for DriverRunner.I think there was some log like this for normal executor when worker shutdown.

@jiangxb1987
Copy link
Contributor

I'm going to close this PR because it goes stale, please feel free to reopen it or open another PR if anyone have more thoughts on this issue.

@asfgit asfgit closed this in ed1478c Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants