Skip to content

Conversation

@gatorsmile
Copy link
Member

What changes were proposed in this pull request?

Fixed non-thread-safe functions used in SessionCatalog:

  • refreshTable
  • lookupRelation

How was this patch tested?

N/A

@gatorsmile
Copy link
Member Author

cc @zsxwing @cloud-fan @yhuai

@gatorsmile
Copy link
Member Author

gatorsmile commented Dec 29, 2016

One related PR: #12915

@SparkQA
Copy link

SparkQA commented Dec 29, 2016

Test build #70724 has finished for PR 16437 at commit 722a0e2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

LGTM, merging to master

@cloud-fan
Copy link
Contributor

cloud-fan commented Dec 31, 2016

shall we backport it to 2.1/2.0?

@gatorsmile
Copy link
Member Author

I think we need to backport it.

@markhamstra
Copy link
Contributor

Please update the description in the JIRA ticket. What is there now is simply not adequate, meaning that if anyone has to come back and address this issue some time on the future, what is there does not describe why a change was needed sufficiently for that person to avoid needing to look at the details in the code (which may well be quite different by that time.)

@gatorsmile
Copy link
Member Author

@markhamstra The JIRA is updated.

@asfgit asfgit closed this in 35e9740 Jan 1, 2017
asfgit pushed a commit that referenced this pull request Jan 3, 2017
…alog

### What changes were proposed in this pull request?
Fixed non-thread-safe functions used in SessionCatalog:
- refreshTable
- lookupRelation

### How was this patch tested?
N/A

Author: gatorsmile <[email protected]>

Closes #16437 from gatorsmile/addSyncToLookUpTable.

(cherry picked from commit 35e9740)
Signed-off-by: Wenchen Fan <[email protected]>
@cloud-fan
Copy link
Contributor

@gatorsmile it conflicts with branch 2.0, please send a new PR, thanks!

cmonkey pushed a commit to cmonkey/spark that referenced this pull request Jan 4, 2017
…alog

### What changes were proposed in this pull request?
Fixed non-thread-safe functions used in SessionCatalog:
- refreshTable
- lookupRelation

### How was this patch tested?
N/A

Author: gatorsmile <[email protected]>

Closes apache#16437 from gatorsmile/addSyncToLookUpTable.
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
…alog

### What changes were proposed in this pull request?
Fixed non-thread-safe functions used in SessionCatalog:
- refreshTable
- lookupRelation

### How was this patch tested?
N/A

Author: gatorsmile <[email protected]>

Closes apache#16437 from gatorsmile/addSyncToLookUpTable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants