[SPARK-15135][SQL]Make sure SparkSession thread safe #12915
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Went through SparkSession and its members and fixed non-thread-safe classes used by SparkSession
Contributor
|
Looks good |
|
Test build #57817 has finished for PR 12915 at commit
|
|
Test build #57823 has finished for PR 12915 at commit
|
Contributor
|
Merging into master 2.0. |
asfgit
pushed a commit
that referenced
this pull request
May 5, 2016
## What changes were proposed in this pull request? Went through SparkSession and its members and fixed non-thread-safe classes used by SparkSession ## How was this patch tested? Existing unit tests Author: Shixiong Zhu <[email protected]> Closes #12915 from zsxwing/spark-session-thread-safe. (cherry picked from commit bb9991d) Signed-off-by: Andrew Or <[email protected]>
| } else { | ||
| tempTables(table) | ||
| } | ||
| val qualifiedTable = SubqueryAlias(table, relation) |
Contributor
There was a problem hiding this comment.
nit: look like this call and alias.map() can be outside the synchronized block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Went through SparkSession and its members and fixed non-thread-safe classes used by SparkSession
How was this patch tested?
Existing unit tests