Skip to content

Conversation

@zsxwing
Copy link
Member

@zsxwing zsxwing commented Dec 1, 2016

What changes were proposed in this pull request?

Avoid to create multiple threads to stop StreamingContext. Otherwise, the latch added in #16091 can be passed too early.

How was this patch tested?

Jenkins

@SparkQA
Copy link

SparkQA commented Dec 1, 2016

Test build #69495 has finished for PR 16105 at commit 31ad69b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member Author

zsxwing commented Dec 1, 2016

cc @rxin

@rxin
Copy link
Contributor

rxin commented Dec 1, 2016

LGTM

@zsxwing
Copy link
Member Author

zsxwing commented Dec 1, 2016

Thanks. Merging to master, 2.1 and 2.0.

@zsxwing zsxwing changed the title [SPARK-18617][Tests]Fix flaky test: StreamingContextSuite.SPARK-18560 Receiver data shoul… [SPARK-18617][Tests]Fix flaky test: StreamingContextSuite.SPARK-18560 Receiver data StreamingContextSuite.SPARK-18560 Receiver data should be deserialized properly Dec 1, 2016
@zsxwing zsxwing changed the title [SPARK-18617][Tests]Fix flaky test: StreamingContextSuite.SPARK-18560 Receiver data StreamingContextSuite.SPARK-18560 Receiver data should be deserialized properly [SPARK-18617][Tests]Fix flaky test: StreamingContextSuite.SPARK-18560 Receiver data should be deserialized properly Dec 1, 2016
asfgit pushed a commit that referenced this pull request Dec 1, 2016
…te. Receiver data should be deserialized properly

## What changes were proposed in this pull request?

Avoid to create multiple threads to stop StreamingContext. Otherwise, the latch added in #16091 can be passed too early.

## How was this patch tested?

Jenkins

Author: Shixiong Zhu <[email protected]>

Closes #16105 from zsxwing/SPARK-18617-2.

(cherry picked from commit 086b0c8)
Signed-off-by: Shixiong Zhu <[email protected]>
asfgit pushed a commit that referenced this pull request Dec 1, 2016
…te. Receiver data should be deserialized properly

## What changes were proposed in this pull request?

Avoid to create multiple threads to stop StreamingContext. Otherwise, the latch added in #16091 can be passed too early.

## How was this patch tested?

Jenkins

Author: Shixiong Zhu <[email protected]>

Closes #16105 from zsxwing/SPARK-18617-2.

(cherry picked from commit 086b0c8)
Signed-off-by: Shixiong Zhu <[email protected]>
@asfgit asfgit closed this in 086b0c8 Dec 1, 2016
@zsxwing zsxwing deleted the SPARK-18617-2 branch December 1, 2016 22:25
robert3005 pushed a commit to palantir/spark that referenced this pull request Dec 2, 2016
…te. Receiver data should be deserialized properly

## What changes were proposed in this pull request?

Avoid to create multiple threads to stop StreamingContext. Otherwise, the latch added in apache#16091 can be passed too early.

## How was this patch tested?

Jenkins

Author: Shixiong Zhu <[email protected]>

Closes apache#16105 from zsxwing/SPARK-18617-2.
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
…te. Receiver data should be deserialized properly

## What changes were proposed in this pull request?

Avoid to create multiple threads to stop StreamingContext. Otherwise, the latch added in apache#16091 can be passed too early.

## How was this patch tested?

Jenkins

Author: Shixiong Zhu <[email protected]>

Closes apache#16105 from zsxwing/SPARK-18617-2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants