[SPARK-18617][Test]Fix flaky test: StreamingContextSuite.SPARK-18560 Receiver data should be deserialized properly #16091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @rxin |
…d be deserialized properly
Contributor
|
LGTM |
|
Test build #69438 has finished for PR 16091 at commit
|
Contributor
|
Merging in master/branch-2.1. |
asfgit
pushed a commit
that referenced
this pull request
Dec 1, 2016
…e. Receiver data should be deserialized properly ## What changes were proposed in this pull request? Fixed the potential SparkContext leak in `StreamingContextSuite.SPARK-18560 Receiver data should be deserialized properly` which was added in #16052. I also removed FakeByteArrayReceiver and used TestReceiver directly. ## How was this patch tested? Jenkins Author: Shixiong Zhu <[email protected]> Closes #16091 from zsxwing/SPARK-18617-follow-up. (cherry picked from commit 0a81121) Signed-off-by: Reynold Xin <[email protected]>
|
Test build #69439 has finished for PR 16091 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Dec 1, 2016
…e for Spark Streaming ## What changes were proposed in this pull request? This is a follow-up PR to backport #16052 to branch-2.0 with incremental update in #16091 ## How was this patch tested? new unit test cc zsxwing rxin Author: uncleGen <[email protected]> Closes #16096 from uncleGen/branch-2.0-SPARK-18617.
asfgit
pushed a commit
that referenced
this pull request
Dec 1, 2016
…te. Receiver data should be deserialized properly ## What changes were proposed in this pull request? Avoid to create multiple threads to stop StreamingContext. Otherwise, the latch added in #16091 can be passed too early. ## How was this patch tested? Jenkins Author: Shixiong Zhu <[email protected]> Closes #16105 from zsxwing/SPARK-18617-2. (cherry picked from commit 086b0c8) Signed-off-by: Shixiong Zhu <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Dec 1, 2016
…te. Receiver data should be deserialized properly ## What changes were proposed in this pull request? Avoid to create multiple threads to stop StreamingContext. Otherwise, the latch added in #16091 can be passed too early. ## How was this patch tested? Jenkins Author: Shixiong Zhu <[email protected]> Closes #16105 from zsxwing/SPARK-18617-2. (cherry picked from commit 086b0c8) Signed-off-by: Shixiong Zhu <[email protected]>
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Dec 1, 2016
…te. Receiver data should be deserialized properly ## What changes were proposed in this pull request? Avoid to create multiple threads to stop StreamingContext. Otherwise, the latch added in apache#16091 can be passed too early. ## How was this patch tested? Jenkins Author: Shixiong Zhu <[email protected]> Closes apache#16105 from zsxwing/SPARK-18617-2.
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 2, 2016
…e. Receiver data should be deserialized properly ## What changes were proposed in this pull request? Fixed the potential SparkContext leak in `StreamingContextSuite.SPARK-18560 Receiver data should be deserialized properly` which was added in apache#16052. I also removed FakeByteArrayReceiver and used TestReceiver directly. ## How was this patch tested? Jenkins Author: Shixiong Zhu <[email protected]> Closes apache#16091 from zsxwing/SPARK-18617-follow-up.
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 2, 2016
…te. Receiver data should be deserialized properly ## What changes were proposed in this pull request? Avoid to create multiple threads to stop StreamingContext. Otherwise, the latch added in apache#16091 can be passed too early. ## How was this patch tested? Jenkins Author: Shixiong Zhu <[email protected]> Closes apache#16105 from zsxwing/SPARK-18617-2.
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 15, 2016
…e. Receiver data should be deserialized properly ## What changes were proposed in this pull request? Fixed the potential SparkContext leak in `StreamingContextSuite.SPARK-18560 Receiver data should be deserialized properly` which was added in apache#16052. I also removed FakeByteArrayReceiver and used TestReceiver directly. ## How was this patch tested? Jenkins Author: Shixiong Zhu <[email protected]> Closes apache#16091 from zsxwing/SPARK-18617-follow-up.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…e. Receiver data should be deserialized properly ## What changes were proposed in this pull request? Fixed the potential SparkContext leak in `StreamingContextSuite.SPARK-18560 Receiver data should be deserialized properly` which was added in apache#16052. I also removed FakeByteArrayReceiver and used TestReceiver directly. ## How was this patch tested? Jenkins Author: Shixiong Zhu <[email protected]> Closes apache#16091 from zsxwing/SPARK-18617-follow-up.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…te. Receiver data should be deserialized properly ## What changes were proposed in this pull request? Avoid to create multiple threads to stop StreamingContext. Otherwise, the latch added in apache#16091 can be passed too early. ## How was this patch tested? Jenkins Author: Shixiong Zhu <[email protected]> Closes apache#16105 from zsxwing/SPARK-18617-2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixed the potential SparkContext leak in
StreamingContextSuite.SPARK-18560 Receiver data should be deserialized properlywhich was added in #16052. I also removed FakeByteArrayReceiver and used TestReceiver directly.How was this patch tested?
Jenkins