Skip to content

[SPARK-17986] [ML] SQLTransformer should remove temporary tables #15526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-17986] [ML] SQLTransformer should remove temporary tables #15526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion mllib/src/main/scala/org/apache/spark/ml/feature/SQLTransformer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,9 @@ class SQLTransformer @Since("1.6.0") (@Since("1.6.0") override val uid: String)
val tableName = Identifiable.randomUID(uid)
dataset.createOrReplaceTempView(tableName)
val realStatement = $(statement).replace(tableIdentifier, tableName)
dataset.sparkSession.sql(realStatement)
val result = dataset.sparkSession.sql(realStatement)
dataset.sparkSession.catalog.dropTempView(tableName)
result
}

@Since("1.6.0")
Expand Down
1 change: 1 addition & 0 deletions mllib/src/test/scala/org/apache/spark/ml/feature/SQLTransformerSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ class SQLTransformerSuite
assert(result.schema.toString == resultSchema.toString)
assert(resultSchema == expected.schema)
assert(result.collect().toSeq == expected.collect().toSeq)
assert(original.sparkSession.catalog.listTables().count() == 0)
Copy link

@leoromanovsky leoromanovsky Oct 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does assert(original.sparkSession.catalog.listTables().isEmpty) work here?

Copy link
Contributor Author

@drewrobb drewrobb Oct 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I believe isEmpty is only currently defined for an RDD, not a Dataset, you could do collect().isEmpty but that would be equally verbose I think.

}

test("read/write") {
Expand Down