[SPARK-17986] [ML] SQLTransformer should remove temporary tables #15526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert(result.schema.toString == resultSchema.toString) | ||
| assert(resultSchema == expected.schema) | ||
| assert(result.collect().toSeq == expected.collect().toSeq) | ||
| assert(original.sparkSession.catalog.listTables().count() == 0) |
There was a problem hiding this comment.
Does assert(original.sparkSession.catalog.listTables().isEmpty) work here?
Contributor
Author
There was a problem hiding this comment.
No, I believe isEmpty is only currently defined for an RDD, not a Dataset, you could do collect().isEmpty but that would be equally verbose I think.
Contributor
Author
|
@yanboliang would you be able to review this patch? |
Contributor
|
cc @srowen @MLnick @jkbradley @rxin Could you add @drewrobb to whitelist? I can not trigger the Jenkins job. Thanks. |
Contributor
|
Jenkins add to whitelist |
|
Test build #67327 has finished for PR 15526 at commit
|
Contributor
|
Good catch! LGTM, merged into master and branch-2.0. Thanks! @drewrobb @leoromanovsky |
asfgit
pushed a commit
that referenced
this pull request
Oct 22, 2016
## What changes were proposed in this pull request? A call to the method `SQLTransformer.transform` previously would create a temporary table and never delete it. This change adds a call to `dropTempView()` that deletes this temporary table before returning the result so that the table will not remain in spark's table catalog. Because `tableName` is randomized and not exposed, there should be no expected use of this table outside of the `transform` method. ## How was this patch tested? A single new assertion was added to the existing test of the `SQLTransformer.transform` method that all temporary tables are removed. Without the corresponding code change, this new assertion fails. I am not aware of any circumstances in which removing this temporary view would be bad for performance or correctness in other ways, but some expertise here would be helpful. Author: Drew Robb <[email protected]> Closes #15526 from drewrobb/SPARK-17986. (cherry picked from commit ab3363e) Signed-off-by: Yanbo Liang <[email protected]>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Nov 1, 2016
## What changes were proposed in this pull request? A call to the method `SQLTransformer.transform` previously would create a temporary table and never delete it. This change adds a call to `dropTempView()` that deletes this temporary table before returning the result so that the table will not remain in spark's table catalog. Because `tableName` is randomized and not exposed, there should be no expected use of this table outside of the `transform` method. ## How was this patch tested? A single new assertion was added to the existing test of the `SQLTransformer.transform` method that all temporary tables are removed. Without the corresponding code change, this new assertion fails. I am not aware of any circumstances in which removing this temporary view would be bad for performance or correctness in other ways, but some expertise here would be helpful. Author: Drew Robb <[email protected]> Closes apache#15526 from drewrobb/SPARK-17986.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? A call to the method `SQLTransformer.transform` previously would create a temporary table and never delete it. This change adds a call to `dropTempView()` that deletes this temporary table before returning the result so that the table will not remain in spark's table catalog. Because `tableName` is randomized and not exposed, there should be no expected use of this table outside of the `transform` method. ## How was this patch tested? A single new assertion was added to the existing test of the `SQLTransformer.transform` method that all temporary tables are removed. Without the corresponding code change, this new assertion fails. I am not aware of any circumstances in which removing this temporary view would be bad for performance or correctness in other ways, but some expertise here would be helpful. Author: Drew Robb <[email protected]> Closes apache#15526 from drewrobb/SPARK-17986.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
A call to the method
SQLTransformer.transformpreviously would create a temporary table and never delete it. This change adds a call todropTempView()that deletes this temporary table before returning the result so that the table will not remain in spark's table catalog. BecausetableNameis randomized and not exposed, there should be no expected use of this table outside of thetransformmethod.How was this patch tested?
A single new assertion was added to the existing test of the
SQLTransformer.transformmethod that all temporary tables are removed. Without the corresponding code change, this new assertion fails. I am not aware of any circumstances in which removing this temporary view would be bad for performance or correctness in other ways, but some expertise here would be helpful.